Re: Review Request 67669: Allowed resources to be removed when updating the sorter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/#review206068 --- Ship it! Ship It! - Jie Yu On July 10, 2018, 8:31 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67669/ > --- > > (Updated July 10, 2018, 8:31 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng > Zhu. > > > Bugs: MESOS-9015 > https://issues.apache.org/jira/browse/MESOS-9015 > > > Repository: mesos > > > Description > --- > > This patch allows the allocator to remove resources when calling > `Sorter::update`, so Mesos can remove resources that are no longer > available through resource conversions. > > An example usage is that we can make `DESTROY_VOLUME` to convert a > volume with a stale profile to an empty resource, so the disk space > will disappear instead of being offered out to other frameworks. > > > Diffs > - > > CHANGELOG 4aef45a28c2127587b003dc0a5e2855ac108e6ff > docs/upgrades.md ef89a7250fba002b0b41030f19c78268190d2671 > src/master/allocator/sorter/drf/sorter.cpp > 755a36ead42a91053c881fc46dc6acb39c819cac > src/master/allocator/sorter/sorter.hpp > e5e86513dc4023d9c471753897635923c6c9203f > src/tests/sorter_tests.cpp 266a9e72597b3aadc9756f61736c0adf0b1a5831 > > > Diff: https://reviews.apache.org/r/67669/diff/5/ > > > Testing > --- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 67669: Allowed resources to be removed when updating the sorter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/ --- (Updated July 10, 2018, 8:31 p.m.) Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng Zhu. Changes --- Addressed Benjamin's comments. Summary (updated) - Allowed resources to be removed when updating the sorter. Bugs: MESOS-9015 https://issues.apache.org/jira/browse/MESOS-9015 Repository: mesos Description --- This patch allows the allocator to remove resources when calling `Sorter::update`, so Mesos can remove resources that are no longer available through resource conversions. An example usage is that we can make `DESTROY_VOLUME` to convert a volume with a stale profile to an empty resource, so the disk space will disappear instead of being offered out to other frameworks. Diffs (updated) - CHANGELOG 4aef45a28c2127587b003dc0a5e2855ac108e6ff docs/upgrades.md ef89a7250fba002b0b41030f19c78268190d2671 src/master/allocator/sorter/drf/sorter.cpp 755a36ead42a91053c881fc46dc6acb39c819cac src/master/allocator/sorter/sorter.hpp e5e86513dc4023d9c471753897635923c6c9203f src/tests/sorter_tests.cpp 266a9e72597b3aadc9756f61736c0adf0b1a5831 Diff: https://reviews.apache.org/r/67669/diff/5/ Changes: https://reviews.apache.org/r/67669/diff/4-5/ Testing --- sudo make check Thanks, Chun-Hung Hsiao
