Re: Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67767/#review205619 --- Ship it! Ship It! - Gilbert Song On June 28, 2018, 12:14 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67767/ > --- > > (Updated June 28, 2018, 12:14 a.m.) > > > Review request for mesos, Gilbert Song and James Peach. > > > Repository: mesos > > > Description > --- > > We do not need to check the isolators ordering because we have made > the order of built-in isolators fixed in MESOS-7643. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > 50668828a9167a2a190922a534c37b145cbfb784 > > > Diff: https://reviews.apache.org/r/67767/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67767/#review205497 --- PASS: Mesos patch 67767 was successfully built and tested. Reviews applied: `['67767']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67767 - Mesos Reviewbot Windows On June 28, 2018, 7:14 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67767/ > --- > > (Updated June 28, 2018, 7:14 a.m.) > > > Review request for mesos, Gilbert Song and James Peach. > > > Repository: mesos > > > Description > --- > > We do not need to check the isolators ordering because we have made > the order of built-in isolators fixed in MESOS-7643. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > 50668828a9167a2a190922a534c37b145cbfb784 > > > Diff: https://reviews.apache.org/r/67767/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Re: Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67767/#review205496 --- Patch looks great! Reviews applied: [67767] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 28, 2018, 7:14 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67767/ > --- > > (Updated June 28, 2018, 7:14 a.m.) > > > Review request for mesos, Gilbert Song and James Peach. > > > Repository: mesos > > > Description > --- > > We do not need to check the isolators ordering because we have made > the order of built-in isolators fixed in MESOS-7643. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > 50668828a9167a2a190922a534c37b145cbfb784 > > > Diff: https://reviews.apache.org/r/67767/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Qian Zhang > >
Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67767/ --- Review request for mesos, Gilbert Song and James Peach. Repository: mesos Description --- We do not need to check the isolators ordering because we have made the order of built-in isolators fixed in MESOS-7643. Diffs - src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 50668828a9167a2a190922a534c37b145cbfb784 Diff: https://reviews.apache.org/r/67767/diff/1/ Testing --- sudo make check Thanks, Qian Zhang
