Re: Review Request 67868: Apply the `override` keyword to Mesos.

2018-07-16 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67868/#review206131
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On July 11, 2018, 10:03 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67868/
> ---
> 
> (Updated July 11, 2018, 10:03 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
> Mesos Reviewbot, Till Toenshoff, and Zhitao Li.
> 
> 
> Bugs: MESOS-9065
> https://issues.apache.org/jira/browse/MESOS-9065
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Apply the `override` keyword to Mesos.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp 6a9e6fc6b1ab94be2ade9a96de4fb11364b46a13 
>   include/mesos/scheduler.hpp d4cc96e86b27cfe2e3a3de448fd0f5e06b1564df 
>   include/mesos/state/in_memory.hpp 3fcf4620b7252c632ca9416d06a5bd1b9ed5a35a 
>   include/mesos/state/leveldb.hpp 265e08b58ea4a50458587f884a98e24cdc5d1aa2 
>   include/mesos/state/log.hpp 54cbdc8d67ef9dfc47b321d5837e09dd56920c94 
>   include/mesos/state/protobuf.hpp c15696ab79b61f5487ee4a849d62b34b91ca1614 
>   include/mesos/state/zookeeper.hpp fee93989c74db031ff2343e06eb25c5a7b88510f 
>   include/mesos/v1/executor.hpp 9a2eb454b0d5d5dce7af03e3100dfd7ae078b5a1 
>   include/mesos/v1/scheduler.hpp b1dfbb1454b550c8a2cd018b1ca9e3533b9171f7 
>   include/mesos/zookeeper/group.hpp 7983e50ba9d240f19a2b3ae02d7fa8339e77f2fa 
>   include/mesos/zookeeper/watcher.hpp 
> b2961a54eae74c5810df5d085a39652991685930 
>   src/authentication/cram_md5/authenticatee.hpp 
> d77b2108c83951f0495b67f6494fb7410592e848 
>   src/authentication/cram_md5/authenticatee.cpp 
> d43dedf1ec86d3f25811718101ff273a7c0d7333 
>   src/authentication/cram_md5/authenticator.hpp 
> a68b2cf43fb5e45bdc2073a9031b72b6f7a1c1bc 
>   src/authentication/cram_md5/authenticator.cpp 
> 0aad3aa9a6a2c70a6e98fc75a3443ea340d0404d 
>   src/authorizer/local/authorizer.hpp 
> 794443ae9e0ec66845bf611d45d6a037ec96ddf4 
>   src/authorizer/local/authorizer.cpp 
> 056b1723f5ec34271f1afe3ad810bc498db8f28e 
>   src/checks/checker_process.hpp 6364af8f0bfbdf7f6596dc0bf32049806bd2ba83 
>   src/cli/execute.cpp 89e5130784e6f18850a743c4e0219245f7658ff3 
>   src/common/http.hpp 76e8f71b5687031344612e1742d3bb50040db758 
>   src/common/recordio.hpp 88e789c7f65c7ac2a97473d656ab15b3803cc886 
>   src/docker/executor.cpp d9f5a736c1cb28a55db1b4fdc793bc706c7cb1fe 
>   src/examples/balloon_executor.cpp 5281db1718f3db462d40d65dfa9ce0e3d9adcc34 
>   src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
>   src/examples/disk_full_framework.cpp 
> dfbdddae7f50d314e67db59300e5140b0476f807 
>   src/examples/docker_no_executor_framework.cpp 
> 0cbda07872fcf7db091c17ef49f5bcea6d80e660 
>   src/examples/dynamic_reservation_framework.cpp 
> e8d8d09dbda95f77e4b7dbbc8e031cd962e3a45f 
>   src/examples/example_module_impl.cpp 
> b84ff73ba96999072a03461f46717c2f104ae9ff 
>   src/examples/load_generator_framework.cpp 
> 3ae25b221185ec6bd4bd84c478be9a511d763162 
>   src/examples/long_lived_executor.cpp 
> 21b511d1d6d0793569ebdb2ecc5c9bc37f3de632 
>   src/examples/long_lived_framework.cpp 
> 0e4e3d00f86ce810ecc273baa4c7d5d124a1a29d 
>   src/examples/no_executor_framework.cpp 
> dc75d7802e43164293c5d68ae78eb7fba6deba64 
>   src/examples/persistent_volume_framework.cpp 
> 43375503f1bdb74fba7994f73beb5b5486026e73 
>   src/examples/test_anonymous_module.cpp 
> c41b7fc6d5feb7760603df1cda8cc0697a815324 
>   src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697 
>   src/examples/test_csi_user_framework.cpp 
> 91212e990af711633f7b890b0c9e10587f9efe7c 
>   src/examples/test_executor.cpp d9b7cdd7dbaf61bc54d7490ab9e7f188ea45f571 
>   src/examples/test_framework.cpp aaf952c20cd3d722d00504228c297c053079bf50 
>   src/examples/test_hook_module.cpp 9b9d75c2bb81bf80e8edb919a04e0854e858f49d 
>   src/examples/test_http_executor.cpp 
> fb9209f630c9c0fa6c1e866eeaf178c560372edc 
>   src/examples/test_http_framework.cpp 
> 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 
>   src/exec/exec.cpp ca4f065af18934a59161ad0ee63daba59beeb115 
>   src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17 
>   src/executor/v0_v1executor.hpp ef9bae6ab75279814a5ba9081aa663107195d8e6 
>   src/executor/v0_v1executor.cpp 086cfc74c820657cb3dd7d531f2de44a97832782 
>   src/files/files.cpp 4b8713a2783ec4c4205af071b6cfff3397ec4c1d 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 39dba40bf94df27a870296810712999009b50506 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> 1f9572c00e1285c5a13f3c2e59c058aab6794ebe 
>   src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 
> 1deeb08337de7cf367c93b8143a035186c06f2bd 
>

Re: Review Request 67868: Apply the `override` keyword to Mesos.

2018-07-16 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67868/#review206122
---


Ship it!




Ship It!

- Benjamin Bannier


On July 12, 2018, 7:03 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67868/
> ---
> 
> (Updated July 12, 2018, 7:03 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
> Mesos Reviewbot, Till Toenshoff, and Zhitao Li.
> 
> 
> Bugs: MESOS-9065
> https://issues.apache.org/jira/browse/MESOS-9065
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Apply the `override` keyword to Mesos.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp 6a9e6fc6b1ab94be2ade9a96de4fb11364b46a13 
>   include/mesos/scheduler.hpp d4cc96e86b27cfe2e3a3de448fd0f5e06b1564df 
>   include/mesos/state/in_memory.hpp 3fcf4620b7252c632ca9416d06a5bd1b9ed5a35a 
>   include/mesos/state/leveldb.hpp 265e08b58ea4a50458587f884a98e24cdc5d1aa2 
>   include/mesos/state/log.hpp 54cbdc8d67ef9dfc47b321d5837e09dd56920c94 
>   include/mesos/state/protobuf.hpp c15696ab79b61f5487ee4a849d62b34b91ca1614 
>   include/mesos/state/zookeeper.hpp fee93989c74db031ff2343e06eb25c5a7b88510f 
>   include/mesos/v1/executor.hpp 9a2eb454b0d5d5dce7af03e3100dfd7ae078b5a1 
>   include/mesos/v1/scheduler.hpp b1dfbb1454b550c8a2cd018b1ca9e3533b9171f7 
>   include/mesos/zookeeper/group.hpp 7983e50ba9d240f19a2b3ae02d7fa8339e77f2fa 
>   include/mesos/zookeeper/watcher.hpp 
> b2961a54eae74c5810df5d085a39652991685930 
>   src/authentication/cram_md5/authenticatee.hpp 
> d77b2108c83951f0495b67f6494fb7410592e848 
>   src/authentication/cram_md5/authenticatee.cpp 
> d43dedf1ec86d3f25811718101ff273a7c0d7333 
>   src/authentication/cram_md5/authenticator.hpp 
> a68b2cf43fb5e45bdc2073a9031b72b6f7a1c1bc 
>   src/authentication/cram_md5/authenticator.cpp 
> 0aad3aa9a6a2c70a6e98fc75a3443ea340d0404d 
>   src/authorizer/local/authorizer.hpp 
> 794443ae9e0ec66845bf611d45d6a037ec96ddf4 
>   src/authorizer/local/authorizer.cpp 
> 056b1723f5ec34271f1afe3ad810bc498db8f28e 
>   src/checks/checker_process.hpp 6364af8f0bfbdf7f6596dc0bf32049806bd2ba83 
>   src/cli/execute.cpp 89e5130784e6f18850a743c4e0219245f7658ff3 
>   src/common/http.hpp 76e8f71b5687031344612e1742d3bb50040db758 
>   src/common/recordio.hpp 88e789c7f65c7ac2a97473d656ab15b3803cc886 
>   src/docker/executor.cpp d9f5a736c1cb28a55db1b4fdc793bc706c7cb1fe 
>   src/examples/balloon_executor.cpp 5281db1718f3db462d40d65dfa9ce0e3d9adcc34 
>   src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
>   src/examples/disk_full_framework.cpp 
> dfbdddae7f50d314e67db59300e5140b0476f807 
>   src/examples/docker_no_executor_framework.cpp 
> 0cbda07872fcf7db091c17ef49f5bcea6d80e660 
>   src/examples/dynamic_reservation_framework.cpp 
> e8d8d09dbda95f77e4b7dbbc8e031cd962e3a45f 
>   src/examples/example_module_impl.cpp 
> b84ff73ba96999072a03461f46717c2f104ae9ff 
>   src/examples/load_generator_framework.cpp 
> 3ae25b221185ec6bd4bd84c478be9a511d763162 
>   src/examples/long_lived_executor.cpp 
> 21b511d1d6d0793569ebdb2ecc5c9bc37f3de632 
>   src/examples/long_lived_framework.cpp 
> 0e4e3d00f86ce810ecc273baa4c7d5d124a1a29d 
>   src/examples/no_executor_framework.cpp 
> dc75d7802e43164293c5d68ae78eb7fba6deba64 
>   src/examples/persistent_volume_framework.cpp 
> 43375503f1bdb74fba7994f73beb5b5486026e73 
>   src/examples/test_anonymous_module.cpp 
> c41b7fc6d5feb7760603df1cda8cc0697a815324 
>   src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697 
>   src/examples/test_csi_user_framework.cpp 
> 91212e990af711633f7b890b0c9e10587f9efe7c 
>   src/examples/test_executor.cpp d9b7cdd7dbaf61bc54d7490ab9e7f188ea45f571 
>   src/examples/test_framework.cpp aaf952c20cd3d722d00504228c297c053079bf50 
>   src/examples/test_hook_module.cpp 9b9d75c2bb81bf80e8edb919a04e0854e858f49d 
>   src/examples/test_http_executor.cpp 
> fb9209f630c9c0fa6c1e866eeaf178c560372edc 
>   src/examples/test_http_framework.cpp 
> 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 
>   src/exec/exec.cpp ca4f065af18934a59161ad0ee63daba59beeb115 
>   src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17 
>   src/executor/v0_v1executor.hpp ef9bae6ab75279814a5ba9081aa663107195d8e6 
>   src/executor/v0_v1executor.cpp 086cfc74c820657cb3dd7d531f2de44a97832782 
>   src/files/files.cpp 4b8713a2783ec4c4205af071b6cfff3397ec4c1d 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 39dba40bf94df27a870296810712999009b50506 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> 1f9572c00e1285c5a13f3c2e59c058aab6794ebe 
>   src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 
> 1deeb08337de7cf367c93b8143a035186c06f2bd 
>

Re: Review Request 67868: Apply the `override` keyword to Mesos.

2018-07-11 Thread James Peach 


> On July 10, 2018, 8:02 a.m., Benjamin Bannier wrote:
> > This change seems a number of possible edits, I see e.g., the ones behind 
> > `JAVA` guards untouched. Could you edit these missing configurations as 
> > well and mentioned the ones you modified in the commit message or _Testing 
> > done_ section?

I used a number of different build setting. The cmake build seems to be missing 
some configurations (e.g. there's no ENABLE_PYTHON, and ENABLE_LIBEVENT doesn't 
build on F28), but I got most of the cases.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67868/#review205900
---


On July 12, 2018, 5:03 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67868/
> ---
> 
> (Updated July 12, 2018, 5:03 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
> Mesos Reviewbot, Till Toenshoff, and Zhitao Li.
> 
> 
> Bugs: MESOS-9065
> https://issues.apache.org/jira/browse/MESOS-9065
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Apply the `override` keyword to Mesos.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp 6a9e6fc6b1ab94be2ade9a96de4fb11364b46a13 
>   include/mesos/scheduler.hpp d4cc96e86b27cfe2e3a3de448fd0f5e06b1564df 
>   include/mesos/state/in_memory.hpp 3fcf4620b7252c632ca9416d06a5bd1b9ed5a35a 
>   include/mesos/state/leveldb.hpp 265e08b58ea4a50458587f884a98e24cdc5d1aa2 
>   include/mesos/state/log.hpp 54cbdc8d67ef9dfc47b321d5837e09dd56920c94 
>   include/mesos/state/protobuf.hpp c15696ab79b61f5487ee4a849d62b34b91ca1614 
>   include/mesos/state/zookeeper.hpp fee93989c74db031ff2343e06eb25c5a7b88510f 
>   include/mesos/v1/executor.hpp 9a2eb454b0d5d5dce7af03e3100dfd7ae078b5a1 
>   include/mesos/v1/scheduler.hpp b1dfbb1454b550c8a2cd018b1ca9e3533b9171f7 
>   include/mesos/zookeeper/group.hpp 7983e50ba9d240f19a2b3ae02d7fa8339e77f2fa 
>   include/mesos/zookeeper/watcher.hpp 
> b2961a54eae74c5810df5d085a39652991685930 
>   src/authentication/cram_md5/authenticatee.hpp 
> d77b2108c83951f0495b67f6494fb7410592e848 
>   src/authentication/cram_md5/authenticatee.cpp 
> d43dedf1ec86d3f25811718101ff273a7c0d7333 
>   src/authentication/cram_md5/authenticator.hpp 
> a68b2cf43fb5e45bdc2073a9031b72b6f7a1c1bc 
>   src/authentication/cram_md5/authenticator.cpp 
> 0aad3aa9a6a2c70a6e98fc75a3443ea340d0404d 
>   src/authorizer/local/authorizer.hpp 
> 794443ae9e0ec66845bf611d45d6a037ec96ddf4 
>   src/authorizer/local/authorizer.cpp 
> 056b1723f5ec34271f1afe3ad810bc498db8f28e 
>   src/checks/checker_process.hpp 6364af8f0bfbdf7f6596dc0bf32049806bd2ba83 
>   src/cli/execute.cpp 89e5130784e6f18850a743c4e0219245f7658ff3 
>   src/common/http.hpp 76e8f71b5687031344612e1742d3bb50040db758 
>   src/common/recordio.hpp 88e789c7f65c7ac2a97473d656ab15b3803cc886 
>   src/docker/executor.cpp d9f5a736c1cb28a55db1b4fdc793bc706c7cb1fe 
>   src/examples/balloon_executor.cpp 5281db1718f3db462d40d65dfa9ce0e3d9adcc34 
>   src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
>   src/examples/disk_full_framework.cpp 
> dfbdddae7f50d314e67db59300e5140b0476f807 
>   src/examples/docker_no_executor_framework.cpp 
> 0cbda07872fcf7db091c17ef49f5bcea6d80e660 
>   src/examples/dynamic_reservation_framework.cpp 
> e8d8d09dbda95f77e4b7dbbc8e031cd962e3a45f 
>   src/examples/example_module_impl.cpp 
> b84ff73ba96999072a03461f46717c2f104ae9ff 
>   src/examples/load_generator_framework.cpp 
> 3ae25b221185ec6bd4bd84c478be9a511d763162 
>   src/examples/long_lived_executor.cpp 
> 21b511d1d6d0793569ebdb2ecc5c9bc37f3de632 
>   src/examples/long_lived_framework.cpp 
> 0e4e3d00f86ce810ecc273baa4c7d5d124a1a29d 
>   src/examples/no_executor_framework.cpp 
> dc75d7802e43164293c5d68ae78eb7fba6deba64 
>   src/examples/persistent_volume_framework.cpp 
> 43375503f1bdb74fba7994f73beb5b5486026e73 
>   src/examples/test_anonymous_module.cpp 
> c41b7fc6d5feb7760603df1cda8cc0697a815324 
>   src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697 
>   src/examples/test_csi_user_framework.cpp 
> 91212e990af711633f7b890b0c9e10587f9efe7c 
>   src/examples/test_executor.cpp d9b7cdd7dbaf61bc54d7490ab9e7f188ea45f571 
>   src/examples/test_framework.cpp aaf952c20cd3d722d00504228c297c053079bf50 
>   src/examples/test_hook_module.cpp 9b9d75c2bb81bf80e8edb919a04e0854e858f49d 
>   src/examples/test_http_executor.cpp 
> fb9209f630c9c0fa6c1e866eeaf178c560372edc 
>   src/examples/test_http_framework.cpp 
> 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 
>   src/exec/exec.cpp ca4f065af18934a59161ad0ee63daba59beeb115 
>   src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17 
>   src/executor/v0_v1executor.hpp

Re: Review Request 67868: Apply the `override` keyword to Mesos.

2018-07-11 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67868/
---

(Updated July 12, 2018, 5:03 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
Mesos Reviewbot, Till Toenshoff, and Zhitao Li.


Bugs: MESOS-9065
https://issues.apache.org/jira/browse/MESOS-9065


Repository: mesos


Description
---

Apply the `override` keyword to Mesos.


Diffs (updated)
-

  include/mesos/executor.hpp 6a9e6fc6b1ab94be2ade9a96de4fb11364b46a13 
  include/mesos/scheduler.hpp d4cc96e86b27cfe2e3a3de448fd0f5e06b1564df 
  include/mesos/state/in_memory.hpp 3fcf4620b7252c632ca9416d06a5bd1b9ed5a35a 
  include/mesos/state/leveldb.hpp 265e08b58ea4a50458587f884a98e24cdc5d1aa2 
  include/mesos/state/log.hpp 54cbdc8d67ef9dfc47b321d5837e09dd56920c94 
  include/mesos/state/protobuf.hpp c15696ab79b61f5487ee4a849d62b34b91ca1614 
  include/mesos/state/zookeeper.hpp fee93989c74db031ff2343e06eb25c5a7b88510f 
  include/mesos/v1/executor.hpp 9a2eb454b0d5d5dce7af03e3100dfd7ae078b5a1 
  include/mesos/v1/scheduler.hpp b1dfbb1454b550c8a2cd018b1ca9e3533b9171f7 
  include/mesos/zookeeper/group.hpp 7983e50ba9d240f19a2b3ae02d7fa8339e77f2fa 
  include/mesos/zookeeper/watcher.hpp b2961a54eae74c5810df5d085a39652991685930 
  src/authentication/cram_md5/authenticatee.hpp 
d77b2108c83951f0495b67f6494fb7410592e848 
  src/authentication/cram_md5/authenticatee.cpp 
d43dedf1ec86d3f25811718101ff273a7c0d7333 
  src/authentication/cram_md5/authenticator.hpp 
a68b2cf43fb5e45bdc2073a9031b72b6f7a1c1bc 
  src/authentication/cram_md5/authenticator.cpp 
0aad3aa9a6a2c70a6e98fc75a3443ea340d0404d 
  src/authorizer/local/authorizer.hpp 794443ae9e0ec66845bf611d45d6a037ec96ddf4 
  src/authorizer/local/authorizer.cpp 056b1723f5ec34271f1afe3ad810bc498db8f28e 
  src/checks/checker_process.hpp 6364af8f0bfbdf7f6596dc0bf32049806bd2ba83 
  src/cli/execute.cpp 89e5130784e6f18850a743c4e0219245f7658ff3 
  src/common/http.hpp 76e8f71b5687031344612e1742d3bb50040db758 
  src/common/recordio.hpp 88e789c7f65c7ac2a97473d656ab15b3803cc886 
  src/docker/executor.cpp d9f5a736c1cb28a55db1b4fdc793bc706c7cb1fe 
  src/examples/balloon_executor.cpp 5281db1718f3db462d40d65dfa9ce0e3d9adcc34 
  src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
  src/examples/disk_full_framework.cpp dfbdddae7f50d314e67db59300e5140b0476f807 
  src/examples/docker_no_executor_framework.cpp 
0cbda07872fcf7db091c17ef49f5bcea6d80e660 
  src/examples/dynamic_reservation_framework.cpp 
e8d8d09dbda95f77e4b7dbbc8e031cd962e3a45f 
  src/examples/example_module_impl.cpp b84ff73ba96999072a03461f46717c2f104ae9ff 
  src/examples/load_generator_framework.cpp 
3ae25b221185ec6bd4bd84c478be9a511d763162 
  src/examples/long_lived_executor.cpp 21b511d1d6d0793569ebdb2ecc5c9bc37f3de632 
  src/examples/long_lived_framework.cpp 
0e4e3d00f86ce810ecc273baa4c7d5d124a1a29d 
  src/examples/no_executor_framework.cpp 
dc75d7802e43164293c5d68ae78eb7fba6deba64 
  src/examples/persistent_volume_framework.cpp 
43375503f1bdb74fba7994f73beb5b5486026e73 
  src/examples/test_anonymous_module.cpp 
c41b7fc6d5feb7760603df1cda8cc0697a815324 
  src/examples/test_csi_plugin.cpp 9c4da8811cc260bcf3bccfea3036a7964cb75697 
  src/examples/test_csi_user_framework.cpp 
91212e990af711633f7b890b0c9e10587f9efe7c 
  src/examples/test_executor.cpp d9b7cdd7dbaf61bc54d7490ab9e7f188ea45f571 
  src/examples/test_framework.cpp aaf952c20cd3d722d00504228c297c053079bf50 
  src/examples/test_hook_module.cpp 9b9d75c2bb81bf80e8edb919a04e0854e858f49d 
  src/examples/test_http_executor.cpp fb9209f630c9c0fa6c1e866eeaf178c560372edc 
  src/examples/test_http_framework.cpp 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 
  src/exec/exec.cpp ca4f065af18934a59161ad0ee63daba59beeb115 
  src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17 
  src/executor/v0_v1executor.hpp ef9bae6ab75279814a5ba9081aa663107195d8e6 
  src/executor/v0_v1executor.cpp 086cfc74c820657cb3dd7d531f2de44a97832782 
  src/files/files.cpp 4b8713a2783ec4c4205af071b6cfff3397ec4c1d 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
39dba40bf94df27a870296810712999009b50506 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
1f9572c00e1285c5a13f3c2e59c058aab6794ebe 
  src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 
1deeb08337de7cf367c93b8143a035186c06f2bd 
  src/launcher/default_executor.cpp a70ba062ac14c851e8e276975b46ba4cc0868243 
  src/launcher/executor.cpp 9fb43c0b741c64f7ad9f3e35b4d81aa627e693dd 
  src/linux/cgroups.cpp b12e63c112a7aa7a6f7150359ff5409f8214067e 
  src/linux/perf.cpp f5ac21df3c2dbaeac0b72444d6e6ef4b3bfe78ca 
  src/log/catchup.cpp ed2e79bff50927e1f5849e8e62662526cac5df1a 
  src/log/consensus.cpp 76ed3e8e8061ea4ca52fe7cae38cbd81b02d5b3d 
  src/log/coordinator.cpp 01d2179f88abf0988192fe1a46640c9e8a0605b4 
  src/log/leveldb.hpp

Re: Review Request 67868: Apply the `override` keyword to Mesos.

2018-07-10 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67868/#review205900
---



This change seems a number of possible edits, I see e.g., the ones behind 
`JAVA` guards untouched. Could you edit these missing configurations as well 
and mentioned the ones you modified in the commit message or _Testing done_ 
section?

- Benjamin Bannier


On July 10, 2018, 5:35 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67868/
> ---
> 
> (Updated July 10, 2018, 5:35 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
> Mesos Reviewbot, Till Toenshoff, and Zhitao Li.
> 
> 
> Bugs: MESOS-9065
> https://issues.apache.org/jira/browse/MESOS-9065
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Apply the `override` keyword to Mesos.
> 
> 
> Diffs
> -
> 
>   include/mesos/executor.hpp 6a9e6fc6b1ab94be2ade9a96de4fb11364b46a13 
>   include/mesos/scheduler.hpp d4cc96e86b27cfe2e3a3de448fd0f5e06b1564df 
>   include/mesos/state/in_memory.hpp 3fcf4620b7252c632ca9416d06a5bd1b9ed5a35a 
>   include/mesos/state/leveldb.hpp 265e08b58ea4a50458587f884a98e24cdc5d1aa2 
>   include/mesos/state/log.hpp 54cbdc8d67ef9dfc47b321d5837e09dd56920c94 
>   include/mesos/state/protobuf.hpp c15696ab79b61f5487ee4a849d62b34b91ca1614 
>   include/mesos/state/zookeeper.hpp fee93989c74db031ff2343e06eb25c5a7b88510f 
>   include/mesos/v1/executor.hpp 9a2eb454b0d5d5dce7af03e3100dfd7ae078b5a1 
>   include/mesos/v1/scheduler.hpp b1dfbb1454b550c8a2cd018b1ca9e3533b9171f7 
>   include/mesos/zookeeper/group.hpp 7983e50ba9d240f19a2b3ae02d7fa8339e77f2fa 
>   include/mesos/zookeeper/watcher.hpp 
> b2961a54eae74c5810df5d085a39652991685930 
>   src/authentication/cram_md5/authenticatee.hpp 
> d77b2108c83951f0495b67f6494fb7410592e848 
>   src/authentication/cram_md5/authenticatee.cpp 
> d43dedf1ec86d3f25811718101ff273a7c0d7333 
>   src/authentication/cram_md5/authenticator.hpp 
> a68b2cf43fb5e45bdc2073a9031b72b6f7a1c1bc 
>   src/authentication/cram_md5/authenticator.cpp 
> 0aad3aa9a6a2c70a6e98fc75a3443ea340d0404d 
>   src/authorizer/local/authorizer.hpp 
> 794443ae9e0ec66845bf611d45d6a037ec96ddf4 
>   src/authorizer/local/authorizer.cpp 
> 056b1723f5ec34271f1afe3ad810bc498db8f28e 
>   src/checks/checker_process.hpp 6364af8f0bfbdf7f6596dc0bf32049806bd2ba83 
>   src/cli/execute.cpp 89e5130784e6f18850a743c4e0219245f7658ff3 
>   src/common/http.hpp 76e8f71b5687031344612e1742d3bb50040db758 
>   src/common/recordio.hpp 88e789c7f65c7ac2a97473d656ab15b3803cc886 
>   src/docker/executor.cpp d9f5a736c1cb28a55db1b4fdc793bc706c7cb1fe 
>   src/examples/balloon_executor.cpp 5281db1718f3db462d40d65dfa9ce0e3d9adcc34 
>   src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
>   src/examples/disk_full_framework.cpp 
> dfbdddae7f50d314e67db59300e5140b0476f807 
>   src/examples/docker_no_executor_framework.cpp 
> 0cbda07872fcf7db091c17ef49f5bcea6d80e660 
>   src/examples/dynamic_reservation_framework.cpp 
> e8d8d09dbda95f77e4b7dbbc8e031cd962e3a45f 
>   src/examples/example_module_impl.cpp 
> b84ff73ba96999072a03461f46717c2f104ae9ff 
>   src/examples/load_generator_framework.cpp 
> 3ae25b221185ec6bd4bd84c478be9a511d763162 
>   src/examples/long_lived_executor.cpp 
> 21b511d1d6d0793569ebdb2ecc5c9bc37f3de632 
>   src/examples/long_lived_framework.cpp 
> 0e4e3d00f86ce810ecc273baa4c7d5d124a1a29d 
>   src/examples/no_executor_framework.cpp 
> dc75d7802e43164293c5d68ae78eb7fba6deba64 
>   src/examples/persistent_volume_framework.cpp 
> 43375503f1bdb74fba7994f73beb5b5486026e73 
>   src/examples/test_anonymous_module.cpp 
> c41b7fc6d5feb7760603df1cda8cc0697a815324 
>   src/examples/test_csi_user_framework.cpp 
> 91212e990af711633f7b890b0c9e10587f9efe7c 
>   src/examples/test_executor.cpp d9b7cdd7dbaf61bc54d7490ab9e7f188ea45f571 
>   src/examples/test_framework.cpp aaf952c20cd3d722d00504228c297c053079bf50 
>   src/examples/test_hook_module.cpp 9b9d75c2bb81bf80e8edb919a04e0854e858f49d 
>   src/examples/test_http_executor.cpp 
> fb9209f630c9c0fa6c1e866eeaf178c560372edc 
>   src/examples/test_http_framework.cpp 
> 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 
>   src/exec/exec.cpp ca4f065af18934a59161ad0ee63daba59beeb115 
>   src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17 
>   src/executor/v0_v1executor.hpp ef9bae6ab75279814a5ba9081aa663107195d8e6 
>   src/executor/v0_v1executor.cpp 086cfc74c820657cb3dd7d531f2de44a97832782 
>   src/files/files.cpp 4b8713a2783ec4c4205af071b6cfff3397ec4c1d 
>   src/launcher/default_executor.cpp a70ba062ac14c851e8e276975b46ba4cc0868243 
>   src/launcher/executor.cpp 9fb43c0b741c64f7ad9f3e35b4d81aa627e693dd 
>   src/linux/cgroups.cpp

Review Request 67868: Apply the `override` keyword to Mesos.

2018-07-09 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67868/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Greg Mann, 
Mesos Reviewbot, Till Toenshoff, and Zhitao Li.


Bugs: MESOS-9065
https://issues.apache.org/jira/browse/MESOS-9065


Repository: mesos


Description
---

Apply the `override` keyword to Mesos.


Diffs
-

  include/mesos/executor.hpp 6a9e6fc6b1ab94be2ade9a96de4fb11364b46a13 
  include/mesos/scheduler.hpp d4cc96e86b27cfe2e3a3de448fd0f5e06b1564df 
  include/mesos/state/in_memory.hpp 3fcf4620b7252c632ca9416d06a5bd1b9ed5a35a 
  include/mesos/state/leveldb.hpp 265e08b58ea4a50458587f884a98e24cdc5d1aa2 
  include/mesos/state/log.hpp 54cbdc8d67ef9dfc47b321d5837e09dd56920c94 
  include/mesos/state/protobuf.hpp c15696ab79b61f5487ee4a849d62b34b91ca1614 
  include/mesos/state/zookeeper.hpp fee93989c74db031ff2343e06eb25c5a7b88510f 
  include/mesos/v1/executor.hpp 9a2eb454b0d5d5dce7af03e3100dfd7ae078b5a1 
  include/mesos/v1/scheduler.hpp b1dfbb1454b550c8a2cd018b1ca9e3533b9171f7 
  include/mesos/zookeeper/group.hpp 7983e50ba9d240f19a2b3ae02d7fa8339e77f2fa 
  include/mesos/zookeeper/watcher.hpp b2961a54eae74c5810df5d085a39652991685930 
  src/authentication/cram_md5/authenticatee.hpp 
d77b2108c83951f0495b67f6494fb7410592e848 
  src/authentication/cram_md5/authenticatee.cpp 
d43dedf1ec86d3f25811718101ff273a7c0d7333 
  src/authentication/cram_md5/authenticator.hpp 
a68b2cf43fb5e45bdc2073a9031b72b6f7a1c1bc 
  src/authentication/cram_md5/authenticator.cpp 
0aad3aa9a6a2c70a6e98fc75a3443ea340d0404d 
  src/authorizer/local/authorizer.hpp 794443ae9e0ec66845bf611d45d6a037ec96ddf4 
  src/authorizer/local/authorizer.cpp 056b1723f5ec34271f1afe3ad810bc498db8f28e 
  src/checks/checker_process.hpp 6364af8f0bfbdf7f6596dc0bf32049806bd2ba83 
  src/cli/execute.cpp 89e5130784e6f18850a743c4e0219245f7658ff3 
  src/common/http.hpp 76e8f71b5687031344612e1742d3bb50040db758 
  src/common/recordio.hpp 88e789c7f65c7ac2a97473d656ab15b3803cc886 
  src/docker/executor.cpp d9f5a736c1cb28a55db1b4fdc793bc706c7cb1fe 
  src/examples/balloon_executor.cpp 5281db1718f3db462d40d65dfa9ce0e3d9adcc34 
  src/examples/balloon_framework.cpp cbc25e45258b05a645363d4229c0a701baa5481c 
  src/examples/disk_full_framework.cpp dfbdddae7f50d314e67db59300e5140b0476f807 
  src/examples/docker_no_executor_framework.cpp 
0cbda07872fcf7db091c17ef49f5bcea6d80e660 
  src/examples/dynamic_reservation_framework.cpp 
e8d8d09dbda95f77e4b7dbbc8e031cd962e3a45f 
  src/examples/example_module_impl.cpp b84ff73ba96999072a03461f46717c2f104ae9ff 
  src/examples/load_generator_framework.cpp 
3ae25b221185ec6bd4bd84c478be9a511d763162 
  src/examples/long_lived_executor.cpp 21b511d1d6d0793569ebdb2ecc5c9bc37f3de632 
  src/examples/long_lived_framework.cpp 
0e4e3d00f86ce810ecc273baa4c7d5d124a1a29d 
  src/examples/no_executor_framework.cpp 
dc75d7802e43164293c5d68ae78eb7fba6deba64 
  src/examples/persistent_volume_framework.cpp 
43375503f1bdb74fba7994f73beb5b5486026e73 
  src/examples/test_anonymous_module.cpp 
c41b7fc6d5feb7760603df1cda8cc0697a815324 
  src/examples/test_csi_user_framework.cpp 
91212e990af711633f7b890b0c9e10587f9efe7c 
  src/examples/test_executor.cpp d9b7cdd7dbaf61bc54d7490ab9e7f188ea45f571 
  src/examples/test_framework.cpp aaf952c20cd3d722d00504228c297c053079bf50 
  src/examples/test_hook_module.cpp 9b9d75c2bb81bf80e8edb919a04e0854e858f49d 
  src/examples/test_http_executor.cpp fb9209f630c9c0fa6c1e866eeaf178c560372edc 
  src/examples/test_http_framework.cpp 9ea3c6f35bf6464b4c6cfa7ba2eaf4febc168396 
  src/exec/exec.cpp ca4f065af18934a59161ad0ee63daba59beeb115 
  src/executor/executor.cpp ab67caefd82f46eacd33221270b2c408ef70cd17 
  src/executor/v0_v1executor.hpp ef9bae6ab75279814a5ba9081aa663107195d8e6 
  src/executor/v0_v1executor.cpp 086cfc74c820657cb3dd7d531f2de44a97832782 
  src/files/files.cpp 4b8713a2783ec4c4205af071b6cfff3397ec4c1d 
  src/launcher/default_executor.cpp a70ba062ac14c851e8e276975b46ba4cc0868243 
  src/launcher/executor.cpp 9fb43c0b741c64f7ad9f3e35b4d81aa627e693dd 
  src/linux/cgroups.cpp b12e63c112a7aa7a6f7150359ff5409f8214067e 
  src/linux/perf.cpp f5ac21df3c2dbaeac0b72444d6e6ef4b3bfe78ca 
  src/log/catchup.cpp ed2e79bff50927e1f5849e8e62662526cac5df1a 
  src/log/consensus.cpp 76ed3e8e8061ea4ca52fe7cae38cbd81b02d5b3d 
  src/log/coordinator.cpp 01d2179f88abf0988192fe1a46640c9e8a0605b4 
  src/log/leveldb.hpp ce93fdc6160fd1947178546660db7ea3c4a1aa1f 
  src/log/leveldb.cpp 50d7fe576463e017cffd362d649f795261496dda 
  src/log/log.hpp 7cba0b1c8c84e4f7c1c592da94b74486e68a97e1 
  src/log/network.hpp 317ae14f754329b2e6e8521f5488107deb2d2c81 
  src/log/recover.cpp 2167d41098b3bd0fa22807ea9f5616ff79de6d9c 
  src/log/replica.cpp bb5aa8c7b4df6b6e4f5422a5cbc49d5f7b7d6878 
  src/log/tool/benchmark.hpp b58a6598f630fc2b26f776bb2eebae04d719d672 
  src/log/tool/initialize.hpp