Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-17 Thread Jie Yu
> On Aug. 16, 2018, 10:34 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp > > Lines 682 (patched) > > > > > > I'd rather treating fetching v2 schema 2 manifest as an impl. details > > of supporting fetching

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-17 Thread Liangyu Zhao via Review Board
> On Aug. 16, 2018, 10:34 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp > > Lines 682 (patched) > > > > > > I'd rather treating fetching v2 schema 2 manifest as an impl. details > > of supporting fetching

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-16 Thread Jie Yu
> On Aug. 16, 2018, 10:34 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp > > Lines 682 (patched) > > > > > > I'd rather treating fetching v2 schema 2 manifest as an impl. details > > of supporting fetching

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review207427 --- src/docker/spec.cpp Lines 347 (patched)

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-15 Thread Jie Yu
> On Aug. 15, 2018, 8:50 p.m., Jie Yu wrote: > > what’s the filesystem layout for the cache when v2 schema 2 is used? > > The layout for schema 1 is here: > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/provisioner/docker/paths.hpp#L31-L46 > > > > as far as I know,

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-15 Thread Liangyu Zhao via Review Board
> On Aug. 15, 2018, 8:50 p.m., Jie Yu wrote: > > what’s the filesystem layout for the cache when v2 schema 2 is used? > > The layout for schema 1 is here: > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/provisioner/docker/paths.hpp#L31-L46 > > > > as far as I know,

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-15 Thread Jie Yu
> On Aug. 15, 2018, 8:50 p.m., Jie Yu wrote: > > what’s the filesystem layout for the cache when v2 schema 2 is used? > > The layout for schema 1 is here: > > https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/provisioner/docker/paths.hpp#L31-L46 > > > > as far as I know,

Re: Review Request 67931: Windows: Added support for Docker Image Manifest Version 2 Schema 2.

2018-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review207353 --- what’s the filesystem layout for the cache when v2 schema 2 is