Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review212088 --- Ship it! Ship It! - Gilbert Song On Jan. 16, 2019, 5:41

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 15, 2019, 2:39 a.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there is

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/ --- (Updated Jan. 16, 2019, 1:41 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 14, 2019, 3:38 p.m., Gilbert Song wrote: > > include/mesos/seccomp/seccomp.proto > > Lines 21-28 (patched) > > > > > > This is my fault. Sorry, Andrei! > > > > Would you mind moving this .proto to

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 14, 2019, 6:39 p.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there is

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 14, 2019, 11:38 p.m., Gilbert Song wrote: > > include/mesos/seccomp/seccomp.proto > > Lines 21-28 (patched) > > > > > > This is my fault. Sorry, Andrei! > > > > Would you mind moving this .proto

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 15, 2019, 2:39 a.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there is

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 15, 2019, 8:41 a.m., Qian Zhang wrote: > > include/mesos/seccomp/seccomp.proto > > Lines 79 (patched) > > > > > > So the value must be numeric? Do we support other types (like string > > value)? > So the

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 15, 2019, 10:39 a.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211942 --- Fix it, then Ship it! include/mesos/seccomp/seccomp.proto

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 15, 2019, 10:39 a.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 14, 2019, 6:39 p.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there is

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 14, 2019, 6:39 p.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there is

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211986 --- Fix it, then Ship it! include/mesos/mesos.proto Lines

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211972 --- include/mesos/seccomp/seccomp.proto Lines 21-28 (patched)

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 2, 2019, 8:23 p.m., Gilbert Song wrote: > > include/mesos/slave/containerizer.proto > > Lines 197 (patched) > > > > > > As we discussed last time, could we move this protobuf message to > >

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211613 --- include/mesos/slave/containerizer.proto Line 26 (original), 26

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Dec. 21, 2018, 1:23 a.m., Qian Zhang wrote: > > include/mesos/slave/containerizer.proto > > Lines 258 (patched) > > > > > > Should it be `repeated CapabilityInfo.Capability caps`? Good catch. - Gilbert

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Dec. 13, 2018, 12:20 a.m., Gilbert Song wrote: > > include/mesos/slave/containerizer.proto > > Lines 200-215 (patched) > > > > > > I saw you remove all `SCMP_` prefix and implemented a hashmap converter > >

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Dec. 21, 2018, 9:23 a.m., Qian Zhang wrote: > > include/mesos/slave/containerizer.proto > > Lines 197 (patched) > > > > > > Can you please elaborate a bit why our internal json format is > > incompatible with

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211492 --- include/mesos/mesos.proto Lines 3089 (patched)

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Dec. 13, 2018, 8:24 a.m., Gilbert Song wrote: > > include/mesos/slave/containerizer.proto > > Lines 197 (patched) > > > > > > When parsing a profile, I can see unavoidably we have to do some > > transforming

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Dec. 13, 2018, 8:20 a.m., Gilbert Song wrote: > > include/mesos/slave/containerizer.proto > > Lines 200-215 (patched) > > > > > > I saw you remove all `SCMP_` prefix and implemented a hashmap converter > > in

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211275 --- include/mesos/slave/containerizer.proto Lines 197 (patched)

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211264 --- include/mesos/slave/containerizer.proto Lines 200-215 (patched)

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Oct. 22, 2018, 5:18 p.m., James Peach wrote: > > include/mesos/mesos.proto > > Lines 3085 (patched) > > > > > > I'm not sure we should have a default here. The default seccomp profile > > should probably be

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/ --- (Updated Nov. 8, 2018, 3:24 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review209886 --- include/mesos/mesos.proto Lines 3085 (patched)

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/ --- (Updated Aug. 6, 2018, 1:38 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/ --- Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.