Re: Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

2018-08-13 Thread Qian Zhang
> On Aug. 13, 2018, 12:15 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > > Line 373 (original), 373 (patched) > > > > > > Not yours, but could we remove this? I

Re: Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

2018-08-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68214/#review207135 --- Fix it, then Ship it!

Re: Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

2018-08-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68214/ --- (Updated Aug. 7, 2018, 10:18 p.m.) Review request for mesos, Gilbert Song,

Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

2018-08-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68214/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.