Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

2018-08-14 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/#review207270
---


Ship it!




Ship It!

- Gilbert Song


On Aug. 13, 2018, 11:29 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68221/
> ---
> 
> (Updated Aug. 13, 2018, 11:29 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `docker/volume` isolator to honor volume mode.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 76f1a5243c8d5028157f795d851b547a5ce57ac9 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> ab749be6234a5eedc0617a131c126129f43f8d62 
> 
> 
> Diff: https://reviews.apache.org/r/68221/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

2018-08-14 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/
---

(Updated Aug. 14, 2018, 2:29 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Addressed review comments.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `docker/volume` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 


Diff: https://reviews.apache.org/r/68221/diff/3/

Changes: https://reviews.apache.org/r/68221/diff/2-3/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

2018-08-13 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/#review207189
---




src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp
Lines 343 (patched)


ditto


- Gilbert Song


On Aug. 7, 2018, 7:23 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68221/
> ---
> 
> (Updated Aug. 7, 2018, 7:23 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `docker/volume` isolator to honor volume mode.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 76f1a5243c8d5028157f795d851b547a5ce57ac9 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> ab749be6234a5eedc0617a131c126129f43f8d62 
> 
> 
> Diff: https://reviews.apache.org/r/68221/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/
---

(Updated Aug. 7, 2018, 10:23 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `docker/volume` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 


Diff: https://reviews.apache.org/r/68221/diff/2/

Changes: https://reviews.apache.org/r/68221/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `docker/volume` isolator to honor volume mode.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 


Diff: https://reviews.apache.org/r/68221/diff/1/


Testing
---


Thanks,

Qian Zhang