Re: Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Andrew Schwartzmeyer
> On Aug. 20, 2018, 11:18 a.m., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? > > Benjamin Bannier wrote: > Thanks for

Re: Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Benjamin Bannier
> On Aug. 20, 2018, 8:18 p.m., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? > > Benjamin Bannier wrote: > Thanks for

Re: Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Andrew Schwartzmeyer
> On Aug. 20, 2018, 11:18 a.m., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? > > Benjamin Bannier wrote: > Thanks for

Re: Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Benjamin Bannier
> On Aug. 20, 2018, 8:18 nachm., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? Thanks for engaging. The main idea would be

Re: Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68319/#review207624 --- I have to ask: why? I've personally thought it would be nicer to

Re: Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68319/#review207610 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 68319: Put binaries into root folder in libprocess.

2018-08-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68319/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos