Re: Review Request 68343: Moved state serialization into separate function.

2018-08-21 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/ --- (Updated Aug. 21, 2018, 6:47 a.m.) Review request for mesos and Alexander

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/#review207648 --- Ship it! I'll do the last tweaks and commit this for you.

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/ --- (Updated Aug. 20, 2018, 6:34 p.m.) Review request for mesos and Alexander

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-20 Thread Benno Evers
> On Aug. 20, 2018, 9:43 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 3031 (original), 3030-3031 (patched) > > > > > > Is pass-by-value intentional? I think it is required by `async()`, but

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-20 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/ --- (Updated Aug. 20, 2018, 2:08 p.m.) Review request for mesos and Alexander

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/#review207607 --- src/master/master.hpp Lines 1402-1403 (patched)

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/#review207605 --- src/master/http.cpp Line 3031 (original), 3030 (patched)

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-17 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/ --- (Updated Aug. 17, 2018, 7:06 p.m.) Review request for mesos and Alexander

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/#review207410 --- src/master/http.cpp Lines 2876-2878 (patched)

Review Request 68343: Moved state serialization into separate function.

2018-08-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos