Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-05 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review208372 --- Ship it! Ship It! - Gilbert Song On Sept. 3, 2018, 6:53

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/ --- (Updated Sept. 4, 2018, 9:53 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Qian Zhang
> On Aug. 28, 2018, 1:16 a.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > > > > > It looks like we should always call `waitNestedContainer()`

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review208258 --- Ship it! Modulo my comment in the previous review. -

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Alexander Rukletsov
> On Aug. 27, 2018, 5:16 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > > > > > It looks like we should always call `waitNestedContainer()`

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-08-30 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review208145 --- Ship it! Ship It! - Gastón Kleiman On Aug. 24, 2018, 2:54

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-08-29 Thread Qian Zhang
> On Aug. 28, 2018, 1:16 a.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > > > > > It looks like we should always call `waitNestedContainer()`

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-08-28 Thread Qian Zhang
> On Aug. 28, 2018, 1:16 a.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > > > > > It looks like we should always call `waitNestedContainer()`

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-08-28 Thread Qian Zhang
> On Aug. 28, 2018, 1:16 a.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > > > > > It looks like we should always call `waitNestedContainer()`

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-08-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review207984 --- src/checks/checker_process.cpp Lines 878-889 (original), 890-901

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-08-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review207850 --- Patch looks great! Reviews applied: [68495] Passed command:

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-08-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review207848 --- PASS: Mesos patch 68495 was successfully built and tested.

Review Request 68495: Made command check always waits before removing the nested container.

2018-08-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/ --- Review request for mesos, Alexander Rukletsov, Gastón Kleiman, and Gilbert Song.