Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-14 Thread Kapil Arya
> On Sept. 14, 2018, 3:07 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 306 (patched) > > > > > > const ? The value is computed during initialize() call. - Kapil

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-14 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 14, 2018, 3:16 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-14 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208633 --- Fix it, then Ship it! This is great!

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-14 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 14, 2018, 2 p.m.) Review request for mesos, Meng Zhu and Till

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 13, 2018, 7:04 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-13 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208611 --- As discussed offline, let's introduce two constructs: one for the

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-13 Thread Kapil Arya
> On Sept. 11, 2018, 8:14 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 250 (patched) > > > > > > While it does not make a difference, it seems odd to pause the > > allocator

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 13, 2018, 4:22 p.m.) Review request for mesos, Meng Zhu and

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208530 --- src/tests/hierarchical_allocator_benchmarks.cpp Lines 71-82

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Kapil Arya
> On Sept. 4, 2018, 7:25 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 278-279 (patched) > > > > > > I feel there are some ambiguities as to which parameters are > >

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Kapil Arya
> On Sept. 4, 2018, 7:25 p.m., Meng Zhu wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Lines 143 (patched) > > > > > > Let's add a comment here regarding what this is for, and show an > > example of

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/ --- (Updated Sept. 11, 2018, 3:15 p.m.) Review request for mesos, Meng Zhu and