Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208406 --- Fix it, then Ship it! src/master/http.cpp Line 2605 (original)

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208355 --- PASS: Mesos patch 68568 was successfully built and tested. Review

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-05 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/ --- (Updated Sept. 5, 2018, 12:18 p.m.) Review request for mesos and Alexander Rukl

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208299 --- src/master/master.hpp Lines 1611 (patched)

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-04 Thread Alexander Rukletsov
> On Aug. 30, 2018, 11:34 a.m., Benno Evers wrote: > > src/master/readonly_handler.cpp > > Lines 753 (patched) > > > > > > Note that this line had to be changed from `weights[name]` to > > `weights.at(name)` during

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-04 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/ --- (Updated Sept. 4, 2018, 9:39 a.m.) Review request for mesos and Alexander Rukle

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208223 --- Patch looks great! Reviews applied: [68567, 68568] Passed comman

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-08-31 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/ --- (Updated Aug. 31, 2018, 3:08 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-08-30 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208129 --- PASS: Mesos patch 68568 was successfully built and tested. Review

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-08-30 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208125 --- src/master/readonly_handler.cpp Lines 753 (patched)

Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-08-30 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-9194 https://