Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/#review208194 --- Ship it! Ship It! - Benjamin Bannier On Aug. 31, 2018, 7:43

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- (Updated Aug. 31, 2018, 5:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

> On Aug. 31, 2018, 11:31 a.m., Benjamin Bannier wrote: > > m4/ax_append_compile_flags.m4 > > Lines 1 (patched) > > > > > > Let's use the file from upstream `HEAD`, e.g., from > >

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- (Updated Aug. 31, 2018, 5:27 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

> On Aug. 31, 2018, 11:31 a.m., Benjamin Bannier wrote: > > m4/ax_append_compile_flags.m4 > > Lines 1 (patched) > > > > > > Let's use the file from upstream `HEAD`, e.g., from > >

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

> On Aug. 31, 2018, 11:31 a.m., Benjamin Bannier wrote: > > configure.ac > > Line 635 (original), 635 (patched) > > > > > > This code is pretty robust and should work with any compiler. How about > > moving it out

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/#review208165 --- Fix it, then Ship it! LGTM, but to ease future maintenance I'd

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- (Updated Aug. 31, 2018, 1:23 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- (Updated Aug. 30, 2018, 9:16 p.m.) Review request for mesos, Benjamin Bannier

Review Request 68576: Mesos: Used standard macros for appending compile flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68576/ --- Review request for mesos, Benjamin Bannier and James Peach. Bugs: MESOS-9193