Re: Review Request 68596: Made bind backend destroy more robust.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68596/#review208217 --- Ship it! Ship It! - Gilbert Song On Aug. 31, 2018, 9:50 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68596/ > --- > > (Updated Aug. 31, 2018, 9:50 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Gilbert Song. > > > Bugs: MESOS-9196 > https://issues.apache.org/jira/browse/MESOS-9196 > > > Repository: mesos > > > Description > --- > > Use MNT_DETACH for `unmount` so that if there are still processes > holding files or directories in the rootfs (e.g., regular filesystem > indexing), the unmount will still be successful. The kernel will cleanup > the mount when the number of references reach zero. See more details in > MESOS-9196. > > > Diffs > - > > src/slave/containerizer/mesos/provisioner/backends/bind.cpp > 6ad97f98ceb8ceae50d786bfbbf49fd0eebc5c21 > > > Diff: https://reviews.apache.org/r/68596/diff/2/ > > > Testing > --- > > sudo make check > > > Thanks, > > Jie Yu > >
Re: Review Request 68596: Made bind backend destroy more robust.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68596/ --- (Updated Sept. 1, 2018, 4:50 a.m.) Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Changes --- Fixed typos Bugs: MESOS-9196 https://issues.apache.org/jira/browse/MESOS-9196 Repository: mesos Description (updated) --- Use MNT_DETACH for `unmount` so that if there are still processes holding files or directories in the rootfs (e.g., regular filesystem indexing), the unmount will still be successful. The kernel will cleanup the mount when the number of references reach zero. See more details in MESOS-9196. Diffs (updated) - src/slave/containerizer/mesos/provisioner/backends/bind.cpp 6ad97f98ceb8ceae50d786bfbbf49fd0eebc5c21 Diff: https://reviews.apache.org/r/68596/diff/2/ Changes: https://reviews.apache.org/r/68596/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu
Review Request 68596: Made bind backend destroy more robust.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68596/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Bugs: MESOS-9196 https://issues.apache.org/jira/browse/MESOS-9196 Repository: mesos Description --- Use MNT_DETACH for `unmount` so that if there are still processes holding files or directies in the rootfs (e.g., regular filesystem indexing), the unmount will still be successful. The kernel will cleanup the mount when the number of references reach zero. See more details in MESOS-9196. Diffs - src/slave/containerizer/mesos/provisioner/backends/bind.cpp 6ad97f98ceb8ceae50d786bfbbf49fd0eebc5c21 Diff: https://reviews.apache.org/r/68596/diff/1/ Testing --- sudo make check Thanks, Jie Yu
