Re: Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/#review208930 --- Ship it! Ship It! - James Peach On Sept. 22, 2018, 7:53

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-22 Thread Till Toenshoff via Review Board
> On Sept. 21, 2018, 3:57 p.m., James Peach wrote: > > configure.ac > > Line 1491 (original), 1491 (patched) > > > > > > Minor nit, this could be: > > > > ``` > > test "x$without_bundled_libevent" =

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-22 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ --- (Updated Sept. 22, 2018, 7:53 p.m.) Review request for mesos, Benjamin

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-21 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/#review208863 --- Fix it, then Ship it! configure.ac Line 1491 (original), 1491

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-16 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ --- (Updated Sept. 16, 2018, 8:40 p.m.) Review request for mesos, Benjamin

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-16 Thread Till Toenshoff via Review Board
> On Sept. 11, 2018, 11:25 p.m., James Peach wrote: > > 3rdparty/Makefile.am > > Lines 327 (patched) > > > > > > I think that `JEMALLOC_CONFIGURE_ARGS` is a typo? > > > > It reads more clearly to me if you

Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-05 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach.