Re: Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209054 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/ --- (Updated Sept. 26, 2018, 10:19 p.m.) Review request for mesos, Benjamin

Re: Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Till Toenshoff via Review Board
> On Sept. 26, 2018, 10:06 p.m., Benjamin Bannier wrote: > > src/python/native_common/ext_modules.py.in > > Lines 121-126 (patched) > > > > > > As discussed offline, I misunderstood part of the intention here. We >

Re: Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209052 --- src/python/native_common/ext_modules.py.in Lines 121-126

Re: Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Till Toenshoff via Review Board
> On Sept. 26, 2018, 9:48 p.m., Benjamin Bannier wrote: > > src/python/native_common/ext_modules.py.in > > Lines 121-126 (patched) > > > > > > This is inconsistent in checking whether files exist, and also > >

Re: Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209048 --- Fix it, then Ship it! LGTM if this passes CI.

Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/ --- Review request for mesos, Benjamin Bannier, Benno Evers, and James Peach.