Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review211797 --- PASS: Mesos patch 69064 was successfully built and tested. Review

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- (Updated Jan. 8, 2019, 5:01 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review211459 --- Ship it! Ship It! - Greg Mann On Dec. 19, 2018, 6:39 p.m., B

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- (Updated Dec. 19, 2018, 6:39 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Dec. 18, 2018, 8:32 a.m., Greg Mann wrote: > > src/tests/master_load_tests.cpp > > Lines 555 (patched) > > > > > > Can you use some other header to test this case, so that we don't need > > to disable the test?

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Dec. 18, 2018, 8:32 a.m., Greg Mann wrote: > > src/tests/master_load_tests.cpp > > Lines 555 (patched) > > > > > > Can you use some other header to test this case, so that we don't need > > to disable the test?

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review211429 --- src/tests/master_load_tests.cpp Lines 555-556 (patched)

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Dec. 18, 2018, 8:32 a.m., Greg Mann wrote: > > src/tests/master_load_tests.cpp > > Lines 555 (patched) > > > > > > Can you use some other header to test this case, so that we don't need > > to disable the test?

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Dec. 18, 2018, 8:32 a.m., Greg Mann wrote: > > src/tests/master_load_tests.cpp > > Lines 293-297 (patched) > > > > > > Should we add something like > > > > ASSERT_TRUE(Clock::now() - whileLoopStartTime

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- (Updated Dec. 18, 2018, 6:41 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Nov. 26, 2018, 12:25 p.m., Benno Evers wrote: > > src/tests/master_load_tests.cpp > > Lines 216 (patched) > > > > > > I'm not 100% happy about this part, but I also couldn't think of a > > better way to generat

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review211377 --- src/tests/master_load_tests.cpp Lines 96-102 (patched)

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

> On Dec. 1, 2018, 1:06 a.m., Joseph Wu wrote: > > src/tests/master_load_tests.cpp > > Lines 73-101 (patched) > > > > > > In terms of helpers, I added a replacement Authorizer: > > ``` > > // This authorizer i

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- (Updated Dec. 12, 2018, 8:53 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review210989 --- I've given a shot at making the `MasterLoadTest.SimultaneousBatche

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review210858 --- src/tests/master_load_tests.cpp Lines 216 (patched)

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- (Updated Nov. 22, 2018, 1:22 a.m.) Review request for mesos, Alexander Rukletso