Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69103/#review209946 --- Ship it! Ship It! - Jie Yu On Oct. 20, 2018, 9:52 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69103/ > --- > > (Updated Oct. 20, 2018, 9:52 a.m.) > > > Review request for mesos, Armand Grillet, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8978 > https://issues.apache.org/jira/browse/MESOS-8978 > > > Repository: mesos > > > Description > --- > > Previously, we could only launch tasks using the '--tty' flag if they > had a backing docker image (or some other combination of other flags set > that would cause the task to have a 'containerInfo' created for it). > > This commit makes sure that if '--tty' is passed, that a containerInfo > gets created and its TTYInfo field gets populated. > > > Diffs > - > > src/cli/execute.cpp eb5c5646ed84533d39ad2588c78f1c0caa5fccfb > > > Diff: https://reviews.apache.org/r/69103/diff/1/ > > > Testing > --- > > sudo bin/mesos-master.sh \ > --ip=127.0.0.1 \ > --work_dir=/var/lib/mesos > > > sudo bin/mesos-agent.sh > --master=127.0.0.1:5050 \ > --work_dir=/var/lib/mesos > > > sudo src/mesos-execute \ > --master=127.0.0.1:5050 \ > --name=tty-test \ > --tty \ > --command="sh -i" > > $ mesos task attach tty-test > sh-4.3$ > > > Thanks, > > Kevin Klues > >
Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69103/#review209822 --- PASS: Mesos patch 69103 was successfully built and tested. Reviews applied: `['69103']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2498/mesos-review-69103 - Mesos Reviewbot Windows On Oct. 20, 2018, 11:52 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69103/ > --- > > (Updated Oct. 20, 2018, 11:52 a.m.) > > > Review request for mesos, Armand Grillet, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8978 > https://issues.apache.org/jira/browse/MESOS-8978 > > > Repository: mesos > > > Description > --- > > Previously, we could only launch tasks using the '--tty' flag if they > had a backing docker image (or some other combination of other flags set > that would cause the task to have a 'containerInfo' created for it). > > This commit makes sure that if '--tty' is passed, that a containerInfo > gets created and its TTYInfo field gets populated. > > > Diffs > - > > src/cli/execute.cpp eb5c5646ed84533d39ad2588c78f1c0caa5fccfb > > > Diff: https://reviews.apache.org/r/69103/diff/1/ > > > Testing > --- > > sudo bin/mesos-master.sh \ > --ip=127.0.0.1 \ > --work_dir=/var/lib/mesos > > > sudo bin/mesos-agent.sh > --master=127.0.0.1:5050 \ > --work_dir=/var/lib/mesos > > > sudo src/mesos-execute \ > --master=127.0.0.1:5050 \ > --name=tty-test \ > --tty \ > --command="sh -i" > > $ mesos task attach tty-test > sh-4.3$ > > > Thanks, > > Kevin Klues > >
Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69103/ --- (Updated Okt. 20, 2018, 9:52 vorm.) Review request for mesos, Armand Grillet, Gilbert Song, and Jie Yu. Bugs: MESOS-8978 https://issues.apache.org/jira/browse/MESOS-8978 Repository: mesos Description --- Previously, we could only launch tasks using the '--tty' flag if they had a backing docker image (or some other combination of other flags set that would cause the task to have a 'containerInfo' created for it). This commit makes sure that if '--tty' is passed, that a containerInfo gets created and its TTYInfo field gets populated. Diffs - src/cli/execute.cpp eb5c5646ed84533d39ad2588c78f1c0caa5fccfb Diff: https://reviews.apache.org/r/69103/diff/1/ Testing (updated) --- sudo bin/mesos-master.sh \ --ip=127.0.0.1 \ --work_dir=/var/lib/mesos sudo bin/mesos-agent.sh --master=127.0.0.1:5050 \ --work_dir=/var/lib/mesos sudo src/mesos-execute \ --master=127.0.0.1:5050 \ --name=tty-test \ --tty \ --command="sh -i" $ mesos task attach tty-test sh-4.3$ Thanks, Kevin Klues
Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69103/#review209820 --- Ship it! Ship It! - Armand Grillet On Oct. 20, 2018, 10:57 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69103/ > --- > > (Updated Oct. 20, 2018, 10:57 a.m.) > > > Review request for mesos, Armand Grillet, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8978 > https://issues.apache.org/jira/browse/MESOS-8978 > > > Repository: mesos > > > Description > --- > > Previously, we could only launch tasks using the '--tty' flag if they > had a backing docker image (or some other combination of other flags set > that would cause the task to have a 'containerInfo' created for it). > > This commit makes sure that if '--tty' is passed, that a containerInfo > gets created and its TTYInfo field gets populated. > > > Diffs > - > > src/cli/execute.cpp eb5c5646ed84533d39ad2588c78f1c0caa5fccfb > > > Diff: https://reviews.apache.org/r/69103/diff/1/ > > > Testing > --- > > sudo bin/mesos-master.sh \ > --ip=127.0.0.1 \ > --work_dir=/var/lib/mesos > > > sudo bin/mesos-agent.sh > --master=127.0.0.1:5050 \ > --work_dir=/var/lib/mesos > > > sudo src/mesos-execute \ > --master=127.0.0.1:5050 \ > --name=tty-test \ > --tty \ > --command="sh -i" > > > Thanks, > > Kevin Klues > >
Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69103/ --- Review request for mesos, Armand Grillet, Gilbert Song, and Jie Yu. Bugs: MESOS-8978 https://issues.apache.org/jira/browse/MESOS-8978 Repository: mesos Description --- Previously, we could only launch tasks using the '--tty' flag if they had a backing docker image (or some other combination of other flags set that would cause the task to have a 'containerInfo' created for it). This commit makes sure that if '--tty' is passed, that a containerInfo gets created and its TTYInfo field gets populated. Diffs - src/cli/execute.cpp eb5c5646ed84533d39ad2588c78f1c0caa5fccfb Diff: https://reviews.apache.org/r/69103/diff/1/ Testing --- sudo bin/mesos-master.sh \ --ip=127.0.0.1 \ --work_dir=/var/lib/mesos sudo bin/mesos-agent.sh --master=127.0.0.1:5050 \ --work_dir=/var/lib/mesos sudo src/mesos-execute \ --master=127.0.0.1:5050 \ --name=tty-test \ --tty \ --command="sh -i" Thanks, Kevin Klues
