Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review211138 --- Ship it! Ship It! - Benno Evers On Dec. 5, 2018, 10:01 p.m.,

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review211079 --- Ship it! Ship It! - Greg Mann On Dec. 5, 2018, 10:01 p.m., J

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/ --- (Updated Dec. 5, 2018, 2:01 p.m.) Review request for mesos, Benno Evers, Benjam

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

> On Dec. 4, 2018, 3:52 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 12109 (patched) > > > > > > This seems worthy of LOG(INFO) to me, WDYT? Sure, I can promote it. I don't have much of a preference

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review211032 --- src/master/master.cpp Lines 12109 (patched)

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210995 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/ --- (Updated Nov. 30, 2018, 6:49 p.m.) Review request for mesos, Benno Evers, Benja

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210990 --- src/master/master.cpp Lines 12105-12108 (original), 12105-12108 (

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210958 --- LGTM bar comments left by the other reviewers. docs/configuratio

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210943 --- Patch looks great! Reviews applied: [69307] Passed command: expo

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210869 --- docs/configuration/master.md Lines 429-439 (patched)

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

> On Nov. 27, 2018, 3:33 p.m., Benno Evers wrote: > > src/tests/api_tests.cpp > > Lines 3688 (patched) > > > > > > To be honest, I don't completely understand if this is creating some > > special "unclean shutdown"

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210891 --- The basic approach still looks good to me, so this review mostly c

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210450 --- PASS: Mesos patch 69307 was successfully built and tested. Review

Review Request 69307: Changed master to hold subscribers in a circular buffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Greg Mann. Bugs: