Re: Review Request 69309: Explicitly constructed command line args in parallel runner.

2018-11-12 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69309/
---

(Updated Nov. 12, 2018, 1:39 p.m.)


Review request for mesos and Armand Grillet.


Repository: mesos


Description
---

This fixes issues with flag propagation into shards.


Diffs (updated)
-

  support/mesos-gtest-runner.py 043f1361f92dd5f24b92c010615b76e6cf6a357a 


Diff: https://reviews.apache.org/r/69309/diff/2/

Changes: https://reviews.apache.org/r/69309/diff/1-2/


Testing
---

`../support/mesos-gtest-runner.py 3rdparty/stout/tests/stout-tests`


Thanks,

Benjamin Bannier



Re: Review Request 69309: Explicitly constructed command line args in parallel runner.

2018-11-12 Thread Armand Grillet

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69309/#review210467
---


Fix it, then Ship it!





support/mesos-gtest-runner.py
Line 72 (original), 72 (patched)


s/`command lint`/`command line`


- Armand Grillet


On Nov. 11, 2018, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69309/
> ---
> 
> (Updated Nov. 11, 2018, 1:01 a.m.)
> 
> 
> Review request for mesos and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This fixes issues with flag propagation into shards.
> 
> 
> Diffs
> -
> 
>   support/mesos-gtest-runner.py 043f1361f92dd5f24b92c010615b76e6cf6a357a 
> 
> 
> Diff: https://reviews.apache.org/r/69309/diff/1/
> 
> 
> Testing
> ---
> 
> `../support/mesos-gtest-runner.py 3rdparty/stout/tests/stout-tests`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Review Request 69309: Explicitly constructed command line args in parallel runner.

2018-11-10 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69309/
---

Review request for mesos and Armand Grillet.


Repository: mesos


Description
---

This fixes issues with flag propagation into shards.


Diffs
-

  support/mesos-gtest-runner.py 043f1361f92dd5f24b92c010615b76e6cf6a357a 


Diff: https://reviews.apache.org/r/69309/diff/1/


Testing
---

`../support/mesos-gtest-runner.py 3rdparty/stout/tests/stout-tests`


Thanks,

Benjamin Bannier