Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69369/#review210635
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69368', '69369']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2616/mesos-review-69369

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2616/mesos-review-69369/logs/mesos-tests.log):

```
I1118 23:53:18.400255 43332 executor.cpp:918] Sending SIGTERM to process tree 
at pid 44000 because it is terminating
I1118 23:53:18.402266 41960 master.cpp:1273] Agent 
4c536215-66f1-42b1-836f-10f620cbdaf7-S0 at slave(461)@192.10.1.5:59221 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1118 23:53:18.402266 41960 master.cpp:3289] Disconnecting agent 
4c536215-66f1-42b1-836f-10f620cbdaf7-S0 at slave(461)@192.10.1.5:59221 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1118 23:53:18.402266 41960 master.cpp:3308] Deactivating agent 
4c536215-66f1-42b1-836f-10f620cbdaf7-S0 at slave(461)@192.10.1.5:59221 
(windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1118 23:53:18.403265 37860 hierarchical.cpp:357] Removed framework 
4c536215-66f1-42b1-836f-10f620cbdaf7-
I1118 23:53:18.403265 37860 hierarchical.cpp:801] Agent 
4c536215-66f1-42b1-836f-10f620cbdaf7-S0 deactivated
I1118 23:53:18.404275 37860 containerizer.cpp:2465] Destroying container 
07448fc5-0ae6-4c6d-bf8d-9cce22700ce3 in RUNNING state
I1118 23:53:18.404275 37860 containerizer.cpp:31[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (683 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (703 ms total)

[--] Global test environment tear-down
[==] 1053 tests from 103 test cases ran. (505115 ms total)
[  PASSED  ] 1052 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

32] Transitioning the state of container 07448fc5-0ae6-4c6d-bf8d-9cce22700ce3 
from RUNNING to DESTROYING
I1118 23:53:18.405256 37860 launcher.cpp:161] Asked to destroy container 
07448fc5-0ae6-4c6d-bf8d-9cce22700ce3
W1118 23:53:18.406260 38916 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=4552 to peer '192.10.1.5:61021': IO failed with error 
code: The specified network name is no longer available.

W1118 23:53:18.407261 38916 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=4352 to peer '192.10.1.5:61022': IO failed with error 
code: The specified network name is no longer available.

I1118 23:53:18.469270 40136 containerizer.cpp:2971] Container 
07448fc5-0ae6-4c6d-bf8d-9cce22700ce3 has exited
I1118 23:53:18.500252 38072 master.cpp:1115] Master terminating
I1118 23:53:18.502249 44780 hierarchical.cpp:643] Removed agent 
4c536215-66f1-42b1-836f-10f620cbdaf7-S0
I1118 23:53:19.126962 38916 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Nov. 18, 2018, 10:49 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69369/
> ---
> 
> (Updated Nov. 18, 2018, 10:49 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin 
> Bannier.
> 
> 
> Bugs: MESOS-9317
> https://issues.apache.org/jira/browse/MESOS-9317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the helper function 'collectAuthorizations' to master.hpp. This
> function allows for a simple way to collect authorization futures and
> only if all supplied futures result in an approved authorization will
> the returned future return true.
> 
> All identified areas that were formally triggering MESOS-9317 are
> being updated to make use of this new helper.
> 
> A helper function has been chosen and preferred over copying this
> pattern into the areas that needed a fix to allow for an efficient and
> complete test coverage.
> 
> Additionally we are adding a test validating that new helper.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
>   src/master/master.cpp 9458ff10999d48e40a8596ec4edf1243591bc0d4 
>   src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
>   src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 
> 
> 
> Diff: https://reviews.apache.org/r/69369/diff/3/
> 
> 
> Testing
> ---
> 
> `make check` and internal CI validation.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-18 Thread Till Toenshoff via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69369/
---

(Updated Nov. 18, 2018, 10:49 p.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin 
Bannier.


Changes
---

Added missing include.


Bugs: MESOS-9317
https://issues.apache.org/jira/browse/MESOS-9317


Repository: mesos


Description
---

Adds the helper function 'collectAuthorizations' to master.hpp. This
function allows for a simple way to collect authorization futures and
only if all supplied futures result in an approved authorization will
the returned future return true.

All identified areas that were formally triggering MESOS-9317 are
being updated to make use of this new helper.

A helper function has been chosen and preferred over copying this
pattern into the areas that needed a fix to allow for an efficient and
complete test coverage.

Additionally we are adding a test validating that new helper.


Diffs (updated)
-

  src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
  src/master/master.cpp 9458ff10999d48e40a8596ec4edf1243591bc0d4 
  src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 


Diff: https://reviews.apache.org/r/69369/diff/3/

Changes: https://reviews.apache.org/r/69369/diff/2-3/


Testing
---

`make check` and internal CI validation.


Thanks,

Till Toenshoff

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-17 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69369/#review210625
---



PASS: Mesos patch 69369 was successfully built and tested.

Reviews applied: `['69368', '69369']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2612/mesos-review-69369

- Mesos Reviewbot Windows


On Nov. 18, 2018, 1:25 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69369/
> ---
> 
> (Updated Nov. 18, 2018, 1:25 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin 
> Bannier.
> 
> 
> Bugs: MESOS-9317
> https://issues.apache.org/jira/browse/MESOS-9317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the helper function 'collectAuthorizations' to master.hpp. This
> function allows for a simple way to collect authorization futures and
> only if all supplied futures result in an approved authorization will
> the returned future return true.
> 
> All identified areas that were formally triggering MESOS-9317 are
> being updated to make use of this new helper.
> 
> A helper function has been chosen and preferred over copying this
> pattern into the areas that needed a fix to allow for an efficient and
> complete test coverage.
> 
> Additionally we are adding a test validating that new helper.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
>   src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
>   src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
>   src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 
> 
> 
> Diff: https://reviews.apache.org/r/69369/diff/2/
> 
> 
> Testing
> ---
> 
> `make check` and internal CI validation.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-17 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69369/#review210624
---


Fix it, then Ship it!





src/master/master.hpp
Lines 2362 (patched)


Please include 


- Alexander Rukletsov


On Nov. 18, 2018, 1:25 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69369/
> ---
> 
> (Updated Nov. 18, 2018, 1:25 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin 
> Bannier.
> 
> 
> Bugs: MESOS-9317
> https://issues.apache.org/jira/browse/MESOS-9317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the helper function 'collectAuthorizations' to master.hpp. This
> function allows for a simple way to collect authorization futures and
> only if all supplied futures result in an approved authorization will
> the returned future return true.
> 
> All identified areas that were formally triggering MESOS-9317 are
> being updated to make use of this new helper.
> 
> A helper function has been chosen and preferred over copying this
> pattern into the areas that needed a fix to allow for an efficient and
> complete test coverage.
> 
> Additionally we are adding a test validating that new helper.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
>   src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
>   src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
>   src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 
> 
> 
> Diff: https://reviews.apache.org/r/69369/diff/2/
> 
> 
> Testing
> ---
> 
> `make check` and internal CI validation.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-17 Thread Till Toenshoff via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69369/
---

(Updated Nov. 18, 2018, 1:25 a.m.)


Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin 
Bannier.


Changes
---

Now replaces one more (formally not buggy) authorization collect 
implementation. Adds a comment on the implementation. Fixes a style nit.


Bugs: MESOS-9317
https://issues.apache.org/jira/browse/MESOS-9317


Repository: mesos


Description
---

Adds the helper function 'collectAuthorizations' to master.hpp. This
function allows for a simple way to collect authorization futures and
only if all supplied futures result in an approved authorization will
the returned future return true.
All identified areas that were formally triggering MESOS-9317 are
being updated to make use of this new helper.
A helper function has been chosen and preferred over copying this
pattern into the areas that needed a fix to allow for an efficient and
complete test coverage.
Additionally we are adding a test validating that new helper.


Diffs (updated)
-

  src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
  src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
  src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 


Diff: https://reviews.apache.org/r/69369/diff/2/

Changes: https://reviews.apache.org/r/69369/diff/1-2/


Testing
---

`make check` and internal CI validation.


Thanks,

Till Toenshoff

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-16 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69369/#review210598
---


Ship it!




Ship It!

- Alexander Rojas


On Nov. 16, 2018, 2:54 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69369/
> ---
> 
> (Updated Nov. 16, 2018, 2:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin 
> Bannier.
> 
> 
> Bugs: MESOS-9317
> https://issues.apache.org/jira/browse/MESOS-9317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the helper function 'collectAuthorizations' to master.hpp. This
> function allows for a simple way to collect authorization futures and
> only if all supplied futures result in an approved authorization will
> the returned future return true.
> All identified areas that were formally triggering MESOS-9317 are
> being updated to make use of this new helper.
> A helper function has been chosen and preferred over copying this
> pattern into the areas that needed a fix to allow for an efficient and
> complete test coverage.
> Additionally we are adding a test validating that new helper.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
>   src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
>   src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
>   src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 
> 
> 
> Diff: https://reviews.apache.org/r/69369/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` and internal CI validation.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-15 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69369/#review210591
---



PASS: Mesos patch 69369 was successfully built and tested.

Reviews applied: `['69368', '69369']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2607/mesos-review-69369

- Mesos Reviewbot Windows


On Nov. 16, 2018, 1:54 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69369/
> ---
> 
> (Updated Nov. 16, 2018, 1:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin 
> Bannier.
> 
> 
> Bugs: MESOS-9317
> https://issues.apache.org/jira/browse/MESOS-9317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the helper function 'collectAuthorizations' to master.hpp. This
> function allows for a simple way to collect authorization futures and
> only if all supplied futures result in an approved authorization will
> the returned future return true.
> All identified areas that were formally triggering MESOS-9317 are
> being updated to make use of this new helper.
> A helper function has been chosen and preferred over copying this
> pattern into the areas that needed a fix to allow for an efficient and
> complete test coverage.
> Additionally we are adding a test validating that new helper.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
>   src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
>   src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
>   src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 
> 
> 
> Diff: https://reviews.apache.org/r/69369/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` and internal CI validation.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-15 Thread Till Toenshoff via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69369/
---

Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin 
Bannier.


Bugs: MESOS-9317
https://issues.apache.org/jira/browse/MESOS-9317


Repository: mesos


Description
---

Adds the helper function 'collectAuthorizations' to master.hpp. This
function allows for a simple way to collect authorization futures and
only if all supplied futures result in an approved authorization will
the returned future return true.
All identified areas that were formally triggering MESOS-9317 are
being updated to make use of this new helper.
A helper function has been chosen and preferred over copying this
pattern into the areas that needed a fix to allow for an efficient and
complete test coverage.
Additionally we are adding a test validating that new helper.


Diffs
-

  src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff 
  src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 
  src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d 
  src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 


Diff: https://reviews.apache.org/r/69369/diff/1/


Testing
---

`make check` and internal CI validation.


Thanks,

Till Toenshoff