Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

2019-01-11 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211868 --- Ship it! Ship It! - Qian Zhang On Jan. 11, 2019, 1:08 p.m.,

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

2019-01-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/ --- (Updated Jan. 11, 2019, 5:08 a.m.) Review request for mesos, Deepak Goel, Gilbe

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

2019-01-10 Thread Deepak Goel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211842 --- Ship it! Ship It! - Deepak Goel On Jan. 10, 2019, 8:44 p.m.,

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

2019-01-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211841 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

2019-01-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211840 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 12:44 p.m

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

2019-01-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211838 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp Lines

Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

2019-01-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/ --- Review request for mesos, Deepak Goel, James Peach, and Qian Zhang. Bugs: MESOS