Re: Review Request 69863: Removed an unnecessary '.get()' from a master test.

2019-01-30 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69863/#review212466
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69863']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2834/mesos-review-69863

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2834/mesos-review-69863/logs/mesos-tests.log):

```
W0130 21:42:23.961591 25700 slave.cpp:3934] Ignoring shutdown framework 
579e4b59-a671-4c18-8102-475d15ce84cc- because it is terminating
I0130 21:42:23.965603 22676 master.cpp:1269] Agent 
579e4b59-a671-4c18-8102-475d15ce84cc-S0 at slave(477)@192.10.1.6:55252 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0130 21:42:23.965603 22676 master.cpp:3272] Disconnecting agent 
579e4b59-a671-4c18-8102-475d15ce84cc-S0 at slave(477)@192.10.1.6:55252 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0130 21:42:23.966588 22676 master.cpp:3291] Deactivating agent 
579e4b59-a671-4c18-8102-475d15ce84cc-S0 at slave(477)@192.10.1.6:55252 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0130 21:42:23.966588 26720 hierarchical.cpp:358] Removed framework 
579e4b59-a671-4c18-8102-475d15ce84cc-
I0130 21:42:23.966588 26720 hierarchical.cpp:793] Agent 
579e4b59-a671-4c18-8102-475d15ce84cc-S0 deactivated
I0130 21:42:23.967607 15788 containerizer.cpp:2477] Destroying container 
dbdeea83-333d-4256-8814-4139694e9cf0 in RUNNING state
I0130 21:42:23.967607 15788 containerizer.cpp:3144] Transitioning the state of 
container dbdeea83-333d-4256-8814-4139694e9cf0 from RUNNING to DESTROYING
I0130 21:42:23.968605 15788 launcher.cpp:161] Asked to destroy container 
dbdeea83-333d-4256-8814-4139694e9cf0
W0130 21:42:23.969594 27680 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=5716 to peer '192.10.1.6:57153': IO failed with error 
code: The specified network name is no longer available.

W0130 21:42:23.969594 27680 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=6408 to peer '192.10.1.6:57154': IO failed with error 
code: The specified network name is no longer available.

I0130 21:42:24.056852 22676 containerizer.cpp:2983] Container 
dbdeea83-333d-4256-8814-413969[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (687 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (704 ms total)

[--] Global test environment tear-down
[==] 1095 tests from 104 test cases ran. (507512 ms total)
[  PASSED  ] 1094 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

4e9cf0 has exited
I0130 21:42:24.086869 25700 master.cpp:1109] Master terminating
I0130 21:42:24.087864 22676 hierarchical.cpp:644] Removed agent 
579e4b59-a671-4c18-8102-475d15ce84cc-S0
I0130 21:42:24.490849 27680 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Jan. 30, 2019, 9:32 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69863/
> ---
> 
> (Updated Jan. 30, 2019, 9:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed an unnecessary '.get()' from a master test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 506d45af416f10787391f226ea62101732ee0850 
> 
> 
> Diff: https://reviews.apache.org/r/69863/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 69863: Removed an unnecessary '.get()' from a master test.

2019-01-30 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69863/#review212465
---


Ship it!




Ship It!

- Joseph Wu


On Jan. 30, 2019, 12:32 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69863/
> ---
> 
> (Updated Jan. 30, 2019, 12:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed an unnecessary '.get()' from a master test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 506d45af416f10787391f226ea62101732ee0850 
> 
> 
> Diff: https://reviews.apache.org/r/69863/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 69863: Removed an unnecessary '.get()' from a master test.

2019-01-30 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69863/#review212463
---


Ship it!




Ship It!

- Benjamin Bannier


On Jan. 30, 2019, 9:32 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69863/
> ---
> 
> (Updated Jan. 30, 2019, 9:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed an unnecessary '.get()' from a master test.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 506d45af416f10787391f226ea62101732ee0850 
> 
> 
> Diff: https://reviews.apache.org/r/69863/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Review Request 69863: Removed an unnecessary '.get()' from a master test.

2019-01-30 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69863/
---

Review request for mesos, Benjamin Bannier and Joseph Wu.


Repository: mesos


Description
---

Removed an unnecessary '.get()' from a master test.


Diffs
-

  src/tests/master_tests.cpp 506d45af416f10787391f226ea62101732ee0850 


Diff: https://reviews.apache.org/r/69863/diff/1/


Testing
---


Thanks,

Greg Mann