Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

2019-02-25 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/#review213178
---


Ship it!




Ship It!

- Greg Mann


On Feb. 22, 2019, 12:08 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69872/
> ---
> 
> (Updated Feb. 22, 2019, 12:08 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9542
> https://issues.apache.org/jira/browse/MESOS-9542
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Operations sent to a resource provider may include an OperationID
> in addition to an Operation UUID.  The UUID is sufficient to uniquely
> identify the operation, so it is possible for the resource provider
> to omit the OperationID in its responses to the agent.
> 
> This commit lets the agent fill in any missing ID before updates
> are acted upon, such as being sent to the master.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 
> 
> 
> Diff: https://reviews.apache.org/r/69872/diff/2/
> 
> 
> Testing
> ---
> 
> Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past 
> line 11692.
> 
> That test is rewritten in the subsequent diff though.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

2019-02-21 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/
---

(Updated Feb. 21, 2019, 4:08 p.m.)


Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Changes
---

Added this to the chain of orphan operation patches.  Mostly related to tests.


Bugs: MESOS-9542
https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description
---

Operations sent to a resource provider may include an OperationID
in addition to an Operation UUID.  The UUID is sufficient to uniquely
identify the operation, so it is possible for the resource provider
to omit the OperationID in its responses to the agent.

This commit lets the agent fill in any missing ID before updates
are acted upon, such as being sent to the master.


Diffs
-

  src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 


Diff: https://reviews.apache.org/r/69872/diff/2/


Testing (updated)
---

Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past line 
11692.

That test is rewritten in the subsequent diff though.


Thanks,

Joseph Wu

Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

2019-02-12 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/
---

(Updated Feb. 12, 2019, 6:03 p.m.)


Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Changes
---

Moved the code up a bit.


Repository: mesos


Description
---

Operations sent to a resource provider may include an OperationID
in addition to an Operation UUID.  The UUID is sufficient to uniquely
identify the operation, so it is possible for the resource provider
to omit the OperationID in its responses to the agent.

This commit lets the agent fill in any missing ID before updates
are acted upon, such as being sent to the master.


Diffs (updated)
-

  src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 


Diff: https://reviews.apache.org/r/69872/diff/2/

Changes: https://reviews.apache.org/r/69872/diff/1-2/


Testing
---

Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past line 
11692.

I can probably repurpose that test, if we don't have a CREATE_DISK + feedback 
test already.


Thanks,

Joseph Wu

Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

2019-01-30 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/#review212476
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69872']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2839/mesos-review-69872

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2839/mesos-review-69872/logs/mesos-tests.log):

```
I0131 05:18:37.143903 13316 master.cpp:1269] Agent 
2ee4ad16-252f-43d8-9cfc-3ad5273bef3f-S0 at slave(477)@192.10.1.6:63918 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0131 05:18:37.143903 13316 master.cpp:3272] Disconnecting agent 
2ee4ad16-252f-43d8-9cfc-3ad5273bef3f-S0 at slave(477)@192.10.1.6:63918 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0131 05:18:37.145030 13316 master.cpp:3291] Deactivating agent 
2ee4ad16-252f-43d8-9cfc-3ad5273bef3f-S0 at slave(477)@192.10.1.6:63918 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0131 05:18:37.145030 16648 hierarchical.cpp:358] Removed framework 
2ee4ad16-252f-43d8-9cfc-3ad5273bef3f-
I0131 05:18:37.145030 16648 hierarchical.cpp:793] Agent 
2ee4ad16-252f-43d8-9cfc-3ad5273bef3f-S0 deactivated
I0131 05:18:37.146067 16648 containerizer.cpp:2477] Destroying container 
b1f2046d-0211-42be-abdc-bee77acf2ff0 in RUNNING state
I0131 05:18:37.146067 16648 containerizer.cpp:3144] Transitioning the state of 
container b1f2046d-0211-42be-abdc-bee77acf2ff0 from RUNNING to DESTROYING
I0131 05:18:37.146898 16648 launcher.cpp:161] Asked to destroy container 
b1f2046d-0211-42be-abdc-bee77acf2ff0
W0131 05:18:37.147900 28488 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=10340 to peer '192.10.1.6:49424': IO [   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (688 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)

[--] Global test environment tear-down
[==] 1095 tests from 104 test cases ran. (551625 ms total)
[  PASSED  ] 1093 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 2 FAILED TESTS
  YOU HAVE 231 DISABLED TESTS

failed with error code: The specified network name is no longer available.

W0131 05:18:37.148897 28488 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=10272 to peer '192.10.1.6:49425': IO failed with error 
code: The specified network name is no longer available.

I0131 05:18:37.246955 13316 containerizer.cpp:2983] Container 
b1f2046d-0211-42be-abdc-bee77acf2ff0 has exited
I0131 05:18:37.275897 29344 master.cpp:1109] Master terminating
I0131 05:18:37.276898 20436 hierarchical.cpp:644] Removed agent 
2ee4ad16-252f-43d8-9cfc-3ad5273bef3f-S0
I0131 05:18:37.660959 28488 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Jan. 31, 2019, 2:44 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69872/
> ---
> 
> (Updated Jan. 31, 2019, 2:44 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Operations sent to a resource provider may include an OperationID
> in addition to an Operation UUID.  The UUID is sufficient to uniquely
> identify the operation, so it is possible for the resource provider
> to omit the OperationID in its responses to the agent.
> 
> This commit lets the agent fill in any missing ID before updates
> are acted upon, such as being sent to the master.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 0182dd2ca326723e96eef8c072696ad3c873de0b 
> 
> 
> Diff: https://reviews.apache.org/r/69872/diff/1/
> 
> 
> Testing
> ---
> 
> Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past 
> line 11692.
> 
> I can probably repurpose that test, if we don't have a CREATE_DISK + feedback 
> test already.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 69872: Accounted for possible lack of OperationID in RP responses.

2019-01-30 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/#review212474
---


Fix it, then Ship it!





src/slave/slave.cpp
Lines 8119 (patched)


Let's do the injection before passing it into `updateOperation`.


- Chun-Hung Hsiao


On Jan. 31, 2019, 2:44 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69872/
> ---
> 
> (Updated Jan. 31, 2019, 2:44 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Operations sent to a resource provider may include an OperationID
> in addition to an Operation UUID.  The UUID is sufficient to uniquely
> identify the operation, so it is possible for the resource provider
> to omit the OperationID in its responses to the agent.
> 
> This commit lets the agent fill in any missing ID before updates
> are acted upon, such as being sent to the master.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 0182dd2ca326723e96eef8c072696ad3c873de0b 
> 
> 
> Diff: https://reviews.apache.org/r/69872/diff/1/
> 
> 
> Testing
> ---
> 
> Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past 
> line 11692.
> 
> I can probably repurpose that test, if we don't have a CREATE_DISK + feedback 
> test already.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 69872: Accounted for possible lack of OperationID in RP responses.

2019-01-30 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/
---

Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Repository: mesos


Description
---

Operations sent to a resource provider may include an OperationID
in addition to an Operation UUID.  The UUID is sufficient to uniquely
identify the operation, so it is possible for the resource provider
to omit the OperationID in its responses to the agent.

This commit lets the agent fill in any missing ID before updates
are acted upon, such as being sent to the master.


Diffs
-

  src/slave/slave.cpp 0182dd2ca326723e96eef8c072696ad3c873de0b 


Diff: https://reviews.apache.org/r/69872/diff/1/


Testing
---

Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past line 
11692.

I can probably repurpose that test, if we don't have a CREATE_DISK + feedback 
test already.


Thanks,

Joseph Wu