Re: Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

2019-02-05 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69894/ --- (Updated Feb. 6, 2019, 4:59 a.m.) Review request for mesos, Benjamin Bannier, J

Re: Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

2019-02-05 Thread Chun-Hung Hsiao
> On Feb. 5, 2019, 5:15 p.m., Benjamin Bannier wrote: > > src/master/validation.cpp > > Lines 2577-2579 (patched) > > > > > > Maybe make this more in line with what we already have for `UNRESERVE` > > of persistent

Re: Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

2019-02-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69894/#review212552 --- Fix it, then Ship it! src/master/validation.cpp Lines 2577-257

Re: Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

2019-02-05 Thread James DeFelice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69894/#review212548 --- Ship it! Ship It! - James DeFelice On Feb. 5, 2019, 7:43 a.m

Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

2019-02-04 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69894/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs: M