Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/ --- (Updated Feb. 8, 2019, 9:47 p.m.) Review request for mesos, Benjamin Bannier an

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

> On Feb. 6, 2019, 6:19 a.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1818 (patched) > > > > > > why not put `.allocatableTo(role)` like below? > > ditto blew in the second stag

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

> On Feb. 6, 2019, 6:19 a.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1818 (patched) > > > > > > why not put `.allocatableTo(role)` like below? > > ditto blew in the second stag

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

> On Feb. 6, 2019, 6:19 a.m., Meng Zhu wrote: > > Thanks for fixing this! Can you add a test? Hm.. yeah I pondered that, let me think again if there's a sane test. My first impression was that I would have to write a very particular white box test, which seemed not so great. Any suggestions wo

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/#review212607 --- Ship it! LGTM, this seems to even be a simplification over the

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/#review212601 --- Fix it, then Ship it! Thanks for fixing this! Can you add a tes

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/#review212582 --- PASS: Mesos patch 69902 was successfully built and tested. Review

Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/ --- Review request for mesos, Benjamin Bannier and Meng Zhu. Bugs: MESOS-9554 h