Re: Review Request 70095: Fixed cpplint issues in the Java bindings.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70095/#review213484
---


Fix it, then Ship it!





src/java/jni/convert.cpp
Line 55 (original), 55-56 (patched)


```
// Initialized in `JNI_OnLoad` later in this file.
jweak mesosClassLoader = nullptr;
```


- Alexander Rukletsov


On March 3, 2019, 1:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70095/
> ---
> 
> (Updated March 3, 2019, 1:01 a.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed cpplint issues in the Java bindings.
> 
> 
> Diffs
> -
> 
>   src/java/jni/construct.cpp 2645d9e5282f352bd663dfeb71d5244662773704 
>   src/java/jni/convert.cpp 338eb963cf843dbffc2d59d13171eb987ac2bc65 
>   src/java/jni/org_apache_mesos_Log.cpp 
> 1ffbacff7584a0b70e03588ad16918f136af1937 
>   src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
> 9d1d45667317048916fbdf6537a07061215cac2c 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> 762fe85e181f0e2c9002321d07f8ad4f91638e92 
>   src/java/jni/org_apache_mesos_state_AbstractState.cpp 
> 0f12f4f7763727da51edb72f8e16cc520a783e42 
>   src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
> b06956f5f16cdcbc242e7a0fce39ddb7f214994c 
>   src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
> b2734c6154a700d8f96216209f4b1aeee883e1ae 
>   src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 
> 4e4dd54007d9a4da88acc9e38bd48d1e599d74d3 
>   support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 
> 
> 
> Diff: https://reviews.apache.org/r/70095/diff/2/
> 
> 
> Testing
> ---
> 
> `make check` with enabled Java bindings
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 70095: Fixed cpplint issues in the Java bindings.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70095/
---

Review request for mesos and Gastón Kleiman.


Repository: mesos


Description
---

Fixed cpplint issues in the Java bindings.


Diffs
-

  src/java/jni/construct.cpp 2645d9e5282f352bd663dfeb71d5244662773704 
  src/java/jni/convert.cpp 338eb963cf843dbffc2d59d13171eb987ac2bc65 
  src/java/jni/org_apache_mesos_Log.cpp 
1ffbacff7584a0b70e03588ad16918f136af1937 
  src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 
9d1d45667317048916fbdf6537a07061215cac2c 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
762fe85e181f0e2c9002321d07f8ad4f91638e92 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 
0f12f4f7763727da51edb72f8e16cc520a783e42 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 
b06956f5f16cdcbc242e7a0fce39ddb7f214994c 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp 
b2734c6154a700d8f96216209f4b1aeee883e1ae 
  src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 
4e4dd54007d9a4da88acc9e38bd48d1e599d74d3 
  support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4 


Diff: https://reviews.apache.org/r/70095/diff/1/


Testing
---

`make check` with enabled Java bindings


Thanks,

Benjamin Bannier