Re: Review Request 70129: Updated advanced contributing guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213717 --- PASS: Mesos patch 70129 was successfully built and tested. Reviews applied: `['70129']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2961/mesos-review-70129 - Mesos Reviewbot Windows On March 6, 2019, 6:32 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70129/ > --- > > (Updated March 6, 2019, 6:32 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Removed the instruction to create a reviewboard account > from the advanced contributing guide, since this instruction > became impossible to follow for contributors. > > > Diffs > - > > docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 > > > Diff: https://reviews.apache.org/r/70129/diff/2/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 70129: Updated advanced contributing guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213704 --- PASS: Mesos patch 70129 was successfully built and tested. Reviews applied: `['70129']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2949/mesos-review-70129 - Mesos Reviewbot Windows On March 6, 2019, 6:32 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70129/ > --- > > (Updated March 6, 2019, 6:32 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Removed the instruction to create a reviewboard account > from the advanced contributing guide, since this instruction > became impossible to follow for contributors. > > > Diffs > - > > docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 > > > Diff: https://reviews.apache.org/r/70129/diff/2/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 70129: Updated advanced contributing guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213490 --- Patch looks great! Reviews applied: [70129] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 6, 2019, 2:32 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70129/ > --- > > (Updated March 6, 2019, 2:32 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Removed the instruction to create a reviewboard account > from the advanced contributing guide, since this instruction > became impossible to follow for contributors. > > > Diffs > - > > docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 > > > Diff: https://reviews.apache.org/r/70129/diff/2/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 70129: Updated advanced contributing guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213489 --- As per Benjamin's private comments, I'll wait a few days before committing this so we can clarify the current ReviewBoard status with the ASF Infra team. - Benno Evers On March 6, 2019, 2:32 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70129/ > --- > > (Updated March 6, 2019, 2:32 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Removed the instruction to create a reviewboard account > from the advanced contributing guide, since this instruction > became impossible to follow for contributors. > > > Diffs > - > > docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 > > > Diff: https://reviews.apache.org/r/70129/diff/2/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 70129: Updated advanced contributing guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/ --- (Updated March 6, 2019, 2:32 p.m.) Review request for mesos, Alexander Rukletsov and Benjamin Bannier. Changes --- Slightly changed the wording. Repository: mesos Description --- Removed the instruction to create a reviewboard account from the advanced contributing guide, since this instruction became impossible to follow for contributors. Diffs (updated) - docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 Diff: https://reviews.apache.org/r/70129/diff/2/ Changes: https://reviews.apache.org/r/70129/diff/1-2/ Testing --- Thanks, Benno Evers
Re: Review Request 70129: Updated advanced contributing guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213460 --- Patch looks great! Reviews applied: [70129] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 5, 2019, 6:53 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70129/ > --- > > (Updated March 5, 2019, 6:53 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Removed the instruction to create a reviewboard account > from the advanced contributing guide, since this instruction > became impossible to follow for contributors. > > > Diffs > - > > docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 > > > Diff: https://reviews.apache.org/r/70129/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 70129: Updated advanced contributing guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213444 --- Ship it! Ship It! - Vinod Kone On March 5, 2019, 6:53 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70129/ > --- > > (Updated March 5, 2019, 6:53 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Removed the instruction to create a reviewboard account > from the advanced contributing guide, since this instruction > became impossible to follow for contributors. > > > Diffs > - > > docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 > > > Diff: https://reviews.apache.org/r/70129/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Review Request 70129: Updated advanced contributing guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/ --- Review request for mesos, Alexander Rukletsov and Benjamin Bannier. Repository: mesos Description --- Removed the instruction to create a reviewboard account from the advanced contributing guide, since this instruction became impossible to follow for contributors. Diffs - docs/advanced-contribution.md 28a314178f12cd5b8b7c5b43b1ecb564061c3fe1 Diff: https://reviews.apache.org/r/70129/diff/1/ Testing --- Thanks, Benno Evers
