Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214711
---



Patch looks great!

Reviews applied: [70489]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On April 17, 2019, 12:11 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 17, 2019, 12:11 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214709
---


Ship it!




Ship It!

- Joseph Wu


On April 16, 2019, 5:11 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 16, 2019, 5:11 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Gilbert Song]

> On April 16, 2019, 4:56 p.m., Joseph Wu wrote:
> > docs/container-image.md
> > Line 184 (original), 184 (patched)
> > 
> >
> > Should the link text be `v2 schema1` (not `v1`)?

ah, typo!


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214706
---


On April 16, 2019, 5:11 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 16, 2019, 5:11 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/
---

(Updated April 16, 2019, 5:11 p.m.)


Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.


Repository: mesos


Description
---

Documented docker manifest v2 schema2 support.


Diffs (updated)
-

  docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 


Diff: https://reviews.apache.org/r/70489/diff/2/

Changes: https://reviews.apache.org/r/70489/diff/1-2/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214707
---




docs/container-image.md
Lines 188-190 (patched)


maybe a bit more like this?

```
For privacte registries, the operator needs to configure `curl` with the 
location of required CA certificates.
```


- Till Toenshoff


On April 16, 2019, 11:39 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 16, 2019, 11:39 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 70489: Documented docker manifest v2 schema2 support.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/#review214706
---




docs/container-image.md
Line 184 (original), 184 (patched)


Should the link text be `v2 schema1` (not `v1`)?


- Joseph Wu


On April 16, 2019, 4:39 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70489/
> ---
> 
> (Updated April 16, 2019, 4:39 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented docker manifest v2 schema2 support.
> 
> 
> Diffs
> -
> 
>   docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 
> 
> 
> Diff: https://reviews.apache.org/r/70489/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 70489: Documented docker manifest v2 schema2 support.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70489/
---

Review request for mesos, Jie Yu and Qian Zhang.


Repository: mesos


Description
---

Documented docker manifest v2 schema2 support.


Diffs
-

  docs/container-image.md 3c4520ad4a5391b1202319bb8db27b4d1c07a96b 


Diff: https://reviews.apache.org/r/70489/diff/1/


Testing
---


Thanks,

Gilbert Song