Re: Review Request 70609: Added missing onDiscard handler in timeout case for `cgroups::destroy`.

2019-05-09 Thread Gilbert Song
> On May 8, 2019, 5:25 p.m., Gilbert Song wrote: > > src/linux/cgroups.cpp > > Lines 1605-1616 (original), 1605-1617 (patched) > > > > > > Seems like the commit description `onDiscarded` does not align with the >

Re: Review Request 70609: Added missing onDiscard handler in timeout case for `cgroups::destroy`.

2019-05-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70609/#review215143 --- src/linux/cgroups.cpp Lines 1605-1616 (original), 1605-1617

Re: Review Request 70609: Added missing onDiscard handler in timeout case for `cgroups::destroy`.

2019-05-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70609/#review215128 --- Patch looks great! Reviews applied: [70609] Passed command:

Review Request 70609: Added missing onDiscard handler in timeout case for `cgroups::destroy`.

2019-05-08 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70609/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Bugs: