Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

2019-05-24 Thread Benjamin Bannier
> On May 14, 2019, 1:37 p.m., Benjamin Bannier wrote: > > src/examples/test_csi_plugin.cpp > > Lines 1250 (patched) > > > > > > Can we do that "normalization" when we initialize `workDir` instead? > > Chun-Hung

Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

2019-05-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70621/#review215495 --- Ship it! LGTM! - Benjamin Bannier On May 22, 2019, 5:03

Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

2019-05-21 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70621/ --- (Updated May 22, 2019, 3:03 a.m.) Review request for mesos and Benjamin

Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

2019-05-21 Thread Chun-Hung Hsiao
> On May 14, 2019, 11:37 a.m., Benjamin Bannier wrote: > > src/examples/test_csi_plugin.cpp > > Line 1253 (original), 1244 (patched) > > > > > > It would be great to have some testing that `getVolumePath -> > >

Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

2019-05-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70621/#review215248 --- src/examples/test_csi_plugin.cpp Lines 215 (patched)

Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

2019-05-09 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70621/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9395