Re: Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/#review216571 --- Ship it! Ship It! - Joseph Wu On June 28, 2019, 2:27 a.m.,

Re: Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/ --- (Updated June 28, 2019, 11:27 a.m.) Review request for mesos, Greg Mann and

Re: Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/#review216217 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 11996

Re: Review Request 70936: Adjusted task status updates during draining.

> On June 25, 2019, 11:48 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 12109 (patched) > > > > > > Maybe we should unconditionally set the reason to > > REASON_AGENT_DRAINING? It doesn't make

Re: Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/ --- (Updated June 27, 2019, 5:23 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 70936: Adjusted task status updates during draining.

> On June 25, 2019, 9:48 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 12109 (patched) > > > > > > Maybe we should unconditionally set the reason to > > REASON_AGENT_DRAINING? It doesn't make

Re: Review Request 70936: Adjusted task status updates during draining.

> On June 26, 2019, 10:16 p.m., Benjamin Bannier wrote: > > src/slave/slave.cpp > > Lines 5732-5734 (patched) > > > > > > I think I got this part incorrect; we should unconditionally set a > >

Re: Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/#review216160 --- src/slave/slave.cpp Lines 5732-5734 (patched)

Re: Review Request 70936: Adjusted task status updates during draining.

> On June 25, 2019, 11:48 p.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 12109 (patched) > > > > > > Maybe we should unconditionally set the reason to > > REASON_AGENT_DRAINING? It doesn't make

Re: Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/ --- (Updated June 26, 2019, 2:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/#review216143 --- src/slave/slave.cpp Lines 5701 (patched)

Review Request 70936: Adjusted task status updates during draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70936/ --- Review request for mesos, Greg Mann and Joseph Wu. Bugs: MESOS-9823