Re: Review Request 71086: Fixed an issue where master quota state is not updated.

2019-07-17 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71086/#review216700
---



Patch looks great!

Reviews applied: [71086]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 16, 2019, 2:22 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71086/
> ---
> 
> (Updated July 16, 2019, 2:22 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a regression test.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 13789d8461fcf029837b15b567ac1b7b97677607 
>   src/tests/master_quota_tests.cpp a1b37693b74778ff6827c9325f1f9225ecf73e58 
> 
> 
> Diff: https://reviews.apache.org/r/71086/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 71086: Fixed an issue where master quota state is not updated.

2019-07-17 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71086/#review216695
---


Ship it!





src/tests/master_quota_tests.cpp
Lines 265-266 (patched)


Maybe wrap the first << on the next line?


- Benjamin Mahler


On July 16, 2019, 9:22 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71086/
> ---
> 
> (Updated July 16, 2019, 9:22 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a regression test.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 13789d8461fcf029837b15b567ac1b7b97677607 
>   src/tests/master_quota_tests.cpp a1b37693b74778ff6827c9325f1f9225ecf73e58 
> 
> 
> Diff: https://reviews.apache.org/r/71086/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 71086: Fixed an issue where master quota state is not updated.

2019-07-16 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71086/#review216674
---



Patch looks great!

Reviews applied: [71086]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 16, 2019, 9:22 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71086/
> ---
> 
> (Updated July 16, 2019, 9:22 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added a regression test.
> 
> 
> Diffs
> -
> 
>   src/master/quota_handler.cpp 13789d8461fcf029837b15b567ac1b7b97677607 
>   src/tests/master_quota_tests.cpp a1b37693b74778ff6827c9325f1f9225ecf73e58 
> 
> 
> Diff: https://reviews.apache.org/r/71086/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 71086: Fixed an issue where master quota state is not updated.

2019-07-16 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71086/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

Also added a regression test.


Diffs
-

  src/master/quota_handler.cpp 13789d8461fcf029837b15b567ac1b7b97677607 
  src/tests/master_quota_tests.cpp a1b37693b74778ff6827c9325f1f9225ecf73e58 


Diff: https://reviews.apache.org/r/71086/diff/1/


Testing
---

make check


Thanks,

Meng Zhu