Re: Review Request 71092: Added additionaly synchronization to a previously flaky test.

2019-07-17 Thread Benno Evers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71092/#review216689
---


Ship it!




Ship It!

- Benno Evers


On July 17, 2019, 12:02 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71092/
> ---
> 
> (Updated July 17, 2019, 12:02 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-9895
> https://issues.apache.org/jira/browse/MESOS-9895
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test did not make sure that the agent's task status update manager
> had received a task status update acknowledgemtn before launching a
> subsequent task. The agent then, given its state, correctly rejected the
> task.
> 
> This patch adds additional synchronization so the agent has finished
> processing the task status update like expected.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 1ed59ca5af69a6b53ceb8be035e608286299c2f1 
> 
> 
> Diff: https://reviews.apache.org/r/71092/diff/1/
> 
> 
> Testing
> ---
> 
> This test previously failed about 4% of the time in ~400 iterations (~20 
> failures) under a lot of additional system stress. With this patch it did not 
> fail once in 500 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Review Request 71092: Added additionaly synchronization to a previously flaky test.

2019-07-17 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71092/
---

Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.


Bugs: MESOS-9895
https://issues.apache.org/jira/browse/MESOS-9895


Repository: mesos


Description
---

This test did not make sure that the agent's task status update manager
had received a task status update acknowledgemtn before launching a
subsequent task. The agent then, given its state, correctly rejected the
task.

This patch adds additional synchronization so the agent has finished
processing the task status update like expected.


Diffs
-

  src/tests/slave_tests.cpp 1ed59ca5af69a6b53ceb8be035e608286299c2f1 


Diff: https://reviews.apache.org/r/71092/diff/1/


Testing
---

This test previously failed about 4% of the time in ~400 iterations (~20 
failures) under a lot of additional system stress. With this patch it did not 
fail once in 500 iterations.


Thanks,

Benjamin Bannier