Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217466 --- Ship it! Ship It! - Joseph Wu On Aug. 27, 2019, 12:57 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71209/ > --- > > (Updated Aug. 27, 2019, 12:57 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9630 > https://issues.apache.org/jira/browse/MESOS-9630 > > > Repository: mesos > > > Description > --- > > This patch enables checkers for well-formed YAML and JSON, and a linter > which checks that all executable scripts have a valid shebang line. > > > Diffs > - > > support/pre-commit-config.yaml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71209/diff/6/ > > > Testing > --- > > * used for development for a couple of months > * reports no issues in the current source tree as indentified issues were > fixed > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/ --- (Updated Aug. 27, 2019, 9:57 a.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-9630 https://issues.apache.org/jira/browse/MESOS-9630 Repository: mesos Description (updated) --- This patch enables checkers for well-formed YAML and JSON, and a linter which checks that all executable scripts have a valid shebang line. Diffs (updated) - support/pre-commit-config.yaml PRE-CREATION Diff: https://reviews.apache.org/r/71209/diff/6/ Changes: https://reviews.apache.org/r/71209/diff/5-6/ Testing --- * used for development for a couple of months * reports no issues in the current source tree as indentified issues were fixed Thanks, Benjamin Bannier
Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217443 --- Ship it! I'ld love to see the commit description to tell us which checks now got activated exactly - the more we explain, the better i feel. - Till Toenshoff On Aug. 19, 2019, 7:20 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71209/ > --- > > (Updated Aug. 19, 2019, 7:20 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9630 > https://issues.apache.org/jira/browse/MESOS-9630 > > > Repository: mesos > > > Description > --- > > Enabled a number of additional pre-commit checks. > > > Diffs > - > > support/pre-commit-config.yaml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71209/diff/5/ > > > Testing > --- > > * used for development for a couple of months > * reports no issues in the current source tree as indentified issues were > fixed > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217284 --- Ship it! Ship It! - Benno Evers On Aug. 19, 2019, 7:20 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71209/ > --- > > (Updated Aug. 19, 2019, 7:20 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9630 > https://issues.apache.org/jira/browse/MESOS-9630 > > > Repository: mesos > > > Description > --- > > Enabled a number of additional pre-commit checks. > > > Diffs > - > > support/pre-commit-config.yaml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71209/diff/5/ > > > Testing > --- > > * used for development for a couple of months > * reports no issues in the current source tree as indentified issues were > fixed > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/ --- (Updated Aug. 19, 2019, 9:20 a.m.) Review request for mesos and Till Toenshoff. Changes --- Rebase Bugs: MESOS-9630 https://issues.apache.org/jira/browse/MESOS-9630 Repository: mesos Description --- Enabled a number of additional pre-commit checks. Diffs (updated) - support/pre-commit-config.yaml PRE-CREATION Diff: https://reviews.apache.org/r/71209/diff/4/ Changes: https://reviews.apache.org/r/71209/diff/3-4/ Testing --- * used for development for a couple of months * reports no issues in the current source tree as indentified issues were fixed Thanks, Benjamin Bannier
Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217270 --- Ship it! Ship It! - James Peach On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71209/ > --- > > (Updated July 30, 2019, 9:01 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9630 > https://issues.apache.org/jira/browse/MESOS-9630 > > > Repository: mesos > > > Description > --- > > Enabled a number of additional pre-commit checks. > > > Diffs > - > > .pre-commit-config.yaml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71209/diff/3/ > > > Testing > --- > > * used for development for a couple of months > * reports no issues in the current source tree as indentified issues were > fixed > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217240 --- Patch looks great! Reviews applied: [70096, 71203, 71204, 71205, 71206, 71207, 71208, 71209] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 31, 2019, 5:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71209/ > --- > > (Updated July 31, 2019, 5:01 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9360 > https://issues.apache.org/jira/browse/MESOS-9360 > > > Repository: mesos > > > Description > --- > > Enabled a number of additional pre-commit checks. > > > Diffs > - > > .pre-commit-config.yaml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71209/diff/1/ > > > Testing > --- > > * used for development for a couple of months > * reports no issues in the current source tree as indentified issues were > fixed > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217204 --- Patch looks great! Reviews applied: [70096, 71203, 71204, 71205, 71206, 71207, 71208, 71209] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71209/ > --- > > (Updated July 30, 2019, 9:01 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9360 > https://issues.apache.org/jira/browse/MESOS-9360 > > > Repository: mesos > > > Description > --- > > Enabled a number of additional pre-commit checks. > > > Diffs > - > > .pre-commit-config.yaml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71209/diff/1/ > > > Testing > --- > > * used for development for a couple of months > * reports no issues in the current source tree as indentified issues were > fixed > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review216983 --- Patch looks great! Reviews applied: [70096, 71203, 71204, 71205, 71206, 71207, 71208, 71209] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71209/ > --- > > (Updated July 30, 2019, 9:01 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9360 > https://issues.apache.org/jira/browse/MESOS-9360 > > > Repository: mesos > > > Description > --- > > Enabled a number of additional pre-commit checks. > > > Diffs > - > > .pre-commit-config.yaml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71209/diff/1/ > > > Testing > --- > > * used for development for a couple of months > * reports no issues in the current source tree as indentified issues were > fixed > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review216975 --- Bad review! Reviews applied: [71209, 71208, 71207, 71206, 71205, 71204, 71203, 70096, 70102, 70101, 70100, 70099, 70098, 70097] Error: Circular dependency detected for review 70096.Please fix the 'depends_on' field. - Mesos Reviewbot On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71209/ > --- > > (Updated July 30, 2019, 9:01 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9360 > https://issues.apache.org/jira/browse/MESOS-9360 > > > Repository: mesos > > > Description > --- > > Enabled a number of additional pre-commit checks. > > > Diffs > - > > .pre-commit-config.yaml PRE-CREATION > > > Diff: https://reviews.apache.org/r/71209/diff/1/ > > > Testing > --- > > * used for development for a couple of months > * reports no issues in the current source tree as indentified issues were > fixed > > > Thanks, > > Benjamin Bannier > >
Review Request 71209: Enabled a number of additional pre-commit checks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9360 https://issues.apache.org/jira/browse/MESOS-9360 Repository: mesos Description --- Enabled a number of additional pre-commit checks. Diffs - .pre-commit-config.yaml PRE-CREATION Diff: https://reviews.apache.org/r/71209/diff/1/ Testing --- * used for development for a couple of months * reports no issues in the current source tree as indentified issues were fixed Thanks, Benjamin Bannier
