Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217424 --- Ship it! Ship It! - James Peach On Aug. 22, 2019, 8:40

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217398 --- Patch looks great! Reviews applied: [71284, 71285] Passed

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

> On Aug. 22, 2019, 2:27 a.m., James Peach wrote: > > src/slave/slave.cpp > > Line 7888 (original) > > > > > > Can you explain this more? > > > > In `Slave::applyOperation()`, there is a call to > >

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- (Updated Aug. 22, 2019, 8:40 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- (Updated Aug. 22, 2019, 8:40 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217373 --- src/slave/slave.cpp Line 7888 (original)

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- (Updated Aug. 21, 2019, 6:29 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217327 --- Patch looks great! Reviews applied: [71284, 71285] Passed

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

> On Aug. 15, 2019, 5:14 a.m., James Peach wrote: > > src/slave/state.cpp > > Lines 819 (patched) > > > > > > `state::read` can already return `None()`, so what do you think about > > letting it return `None()`

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- (Updated Aug. 19, 2019, 10:54 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217215 --- src/slave/slave.cpp Lines 4430 (patched)

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- (Updated Aug. 14, 2019, 10:35 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217198 --- Patch looks great! Reviews applied: [71285] Passed command:

Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- Review request for mesos, Gastón Kleiman, James Peach, and Joseph Wu. Bugs: