Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71301/#review217367 --- Ship it! Ship It! - Benjamin Mahler On Aug. 20, 2019, 11:10

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-20 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71301/ --- (Updated Aug. 20, 2019, 4:10 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-20 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71301/#review217335 --- src/master/allocator/mesos/hierarchical.cpp Line 556 (original),

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-19 Thread Meng Zhu
> On Aug. 19, 2019, 7 a.m., Andrei Sekretenko wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 83 (patched) > > > > > > What is wrong with `FrameworkInfo.id()`? Do we really need a separate > > parame

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-19 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71301/#review217290 --- src/master/allocator/mesos/hierarchical.hpp Lines 83 (patched)

Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-16 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71301/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository: me