Re: Review Request 71336: Fixed deprecation warning when building against OpenSSL 1.1.x.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71336/
---

(Updated Aug. 21, 2019, 11:45 a.m.)


Review request for mesos, Benno Evers and Benjamin Mahler.


Bugs: MESOS-9353
https://issues.apache.org/jira/browse/MESOS-9353


Repository: mesos


Description
---

OpenSSL 1.1.x deprecates 'ASN1_STRING_get_data' and replaces it
by 'ASN1_STRING_get0_data'.


Diffs
-

  3rdparty/libprocess/src/openssl.cpp ee9a049d06bdf6365930aa92873dd97af197eba0 


Diff: https://reviews.apache.org/r/71336/diff/1/


Testing
---

```
cmake .. -DUNBUNDLED_ZOOKEEPER=ON -DUNBUNDLED_LIBEVENT=ON 
-DUNBUNDLED_LEVELDB=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON 
-DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl@1.1 
-DLIBEVENT_ROOT_DIR=/Users/till/usr -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja
ninja tests -j12
```


Thanks,

Till Toenshoff

Re: Review Request 71336: Fixed deprecation warning when building against OpenSSL 1.1.x.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71336/#review217350
---


Fix it, then Ship it!





3rdparty/libprocess/src/openssl.cpp
Line 889 (original), 889 (patched)


Let's add a comment here correlating this with an "normal" version number. 
Is this 1.0.1 (what patch level)?


- Benjamin Bannier


On Aug. 21, 2019, 1:16 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71336/
> ---
> 
> (Updated Aug. 21, 2019, 1:16 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> OpenSSL 1.1.x deprecates 'ASN1_STRING_get_data' and replaces it
> by 'ASN1_STRING_get0_data'.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> ee9a049d06bdf6365930aa92873dd97af197eba0 
> 
> 
> Diff: https://reviews.apache.org/r/71336/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> cmake .. -DUNBUNDLED_ZOOKEEPER=ON -DUNBUNDLED_LIBEVENT=ON 
> -DUNBUNDLED_LEVELDB=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON 
> -DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl@1.1 
> -DLIBEVENT_ROOT_DIR=/Users/till/usr -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja
> ninja tests -j12
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Review Request 71336: Fixed deprecation warning when building against OpenSSL 1.1.x.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71336/
---

Review request for mesos, Benno Evers and Benjamin Mahler.


Repository: mesos


Description
---

OpenSSL 1.1.x deprecates 'ASN1_STRING_get_data' and replaces it
by 'ASN1_STRING_get0_data'.


Diffs
-

  3rdparty/libprocess/src/openssl.cpp ee9a049d06bdf6365930aa92873dd97af197eba0 


Diff: https://reviews.apache.org/r/71336/diff/1/


Testing
---

```
cmake .. -DUNBUNDLED_ZOOKEEPER=ON -DUNBUNDLED_LIBEVENT=ON 
-DUNBUNDLED_LEVELDB=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON 
-DENABLE_LIBEVENT=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl@1.1 
-DLIBEVENT_ROOT_DIR=/Users/till/usr -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja
ninja tests -j12
```


Thanks,

Till Toenshoff