Re: Review Request 71464: Allowed setting quota the default "*" role.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71464/#review217942 --- Ship it! Can you document this in: * quota documentation * release notes * (maybe the upgrade doc, although we need to simplify it since it overlaps with release notes) - Benjamin Mahler On Sept. 10, 2019, 6:56 p.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71464/ > --- > > (Updated Sept. 10, 2019, 6:56 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-3938 > https://issues.apache.org/jira/browse/MESOS-3938 > > > Repository: mesos > > > Description > --- > > There is no clear argument against setting quota on the default > "*" role. This patch allows doing so. Tests are updated to check > against regressions. > > > Diffs > - > > src/master/quota.cpp c9f39f3ef419a6460f3f869582c95d5f3d1a5f40 > src/tests/hierarchical_allocator_tests.cpp > 2c1d0fe2e3ac08e6443cf8348bb72ac7dae454a8 > src/tests/master_quota_tests.cpp 58328692b1026231e3f255938741ffc57324f97d > src/tests/master_validation_tests.cpp > 90b844791ee0788efb8c4b220c246f56f5c9981f > > > Diff: https://reviews.apache.org/r/71464/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Meng Zhu > >
Re: Review Request 71464: Allowed setting quota the default "*" role.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71464/#review217684 --- Patch looks great! Reviews applied: [71464] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 10, 2019, 6:56 p.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71464/ > --- > > (Updated Sept. 10, 2019, 6:56 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-3938 > https://issues.apache.org/jira/browse/MESOS-3938 > > > Repository: mesos > > > Description > --- > > There is no clear argument against setting quota on the default > "*" role. This patch allows doing so. Tests are updated to check > against regressions. > > > Diffs > - > > src/master/quota.cpp c9f39f3ef419a6460f3f869582c95d5f3d1a5f40 > src/tests/hierarchical_allocator_tests.cpp > 2c1d0fe2e3ac08e6443cf8348bb72ac7dae454a8 > src/tests/master_quota_tests.cpp 58328692b1026231e3f255938741ffc57324f97d > src/tests/master_validation_tests.cpp > 90b844791ee0788efb8c4b220c246f56f5c9981f > > > Diff: https://reviews.apache.org/r/71464/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Meng Zhu > >
Review Request 71464: Allowed setting quota the default "*" role.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71464/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: MESOS-3938 https://issues.apache.org/jira/browse/MESOS-3938 Repository: mesos Description --- There is no clear argument against setting quota on the default "*" role. This patch allows doing so. Tests are updated to check against regressions. Diffs - src/master/quota.cpp c9f39f3ef419a6460f3f869582c95d5f3d1a5f40 src/tests/hierarchical_allocator_tests.cpp 2c1d0fe2e3ac08e6443cf8348bb72ac7dae454a8 src/tests/master_quota_tests.cpp 58328692b1026231e3f255938741ffc57324f97d src/tests/master_validation_tests.cpp 90b844791ee0788efb8c4b220c246f56f5c9981f Diff: https://reviews.apache.org/r/71464/diff/1/ Testing --- make check Thanks, Meng Zhu
