Re: Review Request 71481: Added some extra ASSERTs to a role test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71481/#review217719 --- Patch looks great! Reviews applied: [71481] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 13, 2019, 12:48 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71481/ > --- > > (Updated Sept. 13, 2019, 12:48 a.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, and Meng Zhu. > > > Repository: mesos > > > Description > --- > > These asserts technically aren't required, since subsequent > awaiting for offers assumes that the agents are created successfully. > However, it seems useful to fail a bit earlier if the agent creation > happens to fail. > > > Diffs > - > > src/tests/role_tests.cpp d6cc31bf89954c5a440142b378560cdc0286df23 > > > Diff: https://reviews.apache.org/r/71481/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Joseph Wu > >
Re: Review Request 71481: Added some extra ASSERTs to a role test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71481/#review217714 --- Ship it! Ship It! - Meng Zhu On Sept. 12, 2019, 5:48 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71481/ > --- > > (Updated Sept. 12, 2019, 5:48 p.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, and Meng Zhu. > > > Repository: mesos > > > Description > --- > > These asserts technically aren't required, since subsequent > awaiting for offers assumes that the agents are created successfully. > However, it seems useful to fail a bit earlier if the agent creation > happens to fail. > > > Diffs > - > > src/tests/role_tests.cpp d6cc31bf89954c5a440142b378560cdc0286df23 > > > Diff: https://reviews.apache.org/r/71481/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Joseph Wu > >
Review Request 71481: Added some extra ASSERTs to a role test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71481/ --- Review request for mesos, Benjamin Mahler, Greg Mann, and Meng Zhu. Repository: mesos Description --- These asserts technically aren't required, since subsequent awaiting for offers assumes that the agents are created successfully. However, it seems useful to fail a bit earlier if the agent creation happens to fail. Diffs - src/tests/role_tests.cpp d6cc31bf89954c5a440142b378560cdc0286df23 Diff: https://reviews.apache.org/r/71481/diff/1/ Testing --- make check Thanks, Joseph Wu
