Re: Review Request 71560: Made the MaintenanceInverseOffers test use only one framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71560/#review218021 --- Ship it! Thanks for fixing this! - Meng Zhu On Sept. 30, 2019, 6:33 a.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71560/ > --- > > (Updated Sept. 30, 2019, 6:33 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu. > > > Bugs: MESOS-9980 > https://issues.apache.org/jira/browse/MESOS-9980 > > > Repository: mesos > > > Description > --- > > This patch simplifies the test and attepmts to fix MESOS-9980 by > removing the (potential) flakiness caused by agent2's resources > being re-offered to framework2. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > a13eb017f7a93ee67c8426e4150858a547175ed6 > > > Diff: https://reviews.apache.org/r/71560/diff/1/ > > > Testing > --- > > `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" > --gtest_break_on_failure --gtest_repeat=1` > > `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" > --gtest_break_on_failure` fails if I break framework untracking in > `Slave::increaseAvailable()` in the allocator. > > > Thanks, > > Andrei Sekretenko > >
Re: Review Request 71560: Made the MaintenanceInverseOffers test use only one framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71560/#review217995 --- Patch looks great! Reviews applied: [71560] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 30, 2019, 1:33 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71560/ > --- > > (Updated Sept. 30, 2019, 1:33 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu. > > > Bugs: MESOS-9980 > https://issues.apache.org/jira/browse/MESOS-9980 > > > Repository: mesos > > > Description > --- > > This patch simplifies the test and attepmts to fix MESOS-9980 by > removing the (potential) flakiness caused by agent2's resources > being re-offered to framework2. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > a13eb017f7a93ee67c8426e4150858a547175ed6 > > > Diff: https://reviews.apache.org/r/71560/diff/1/ > > > Testing > --- > > `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" > --gtest_break_on_failure --gtest_repeat=1` > > `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" > --gtest_break_on_failure` fails if I break framework untracking in > `Slave::increaseAvailable()` in the allocator. > > > Thanks, > > Andrei Sekretenko > >
Re: Review Request 71560: Made the MaintenanceInverseOffers test use only one framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71560/#review217992 --- Ship it! I put the same stress on the system I put when commenting here, https://issues.apache.org/jira/browse/MESOS-9980?focusedCommentId=16940894&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16940894. The test did not fail once in 200 repetitions (failure rate < 10%), where before it failed roughly 20-40% of the time. - Benjamin Bannier On Sept. 30, 2019, 3:33 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71560/ > --- > > (Updated Sept. 30, 2019, 3:33 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu. > > > Bugs: MESOS-9980 > https://issues.apache.org/jira/browse/MESOS-9980 > > > Repository: mesos > > > Description > --- > > This patch simplifies the test and attepmts to fix MESOS-9980 by > removing the (potential) flakiness caused by agent2's resources > being re-offered to framework2. > > > Diffs > - > > src/tests/hierarchical_allocator_tests.cpp > a13eb017f7a93ee67c8426e4150858a547175ed6 > > > Diff: https://reviews.apache.org/r/71560/diff/1/ > > > Testing > --- > > `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" > --gtest_break_on_failure --gtest_repeat=1` > > `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" > --gtest_break_on_failure` fails if I break framework untracking in > `Slave::increaseAvailable()` in the allocator. > > > Thanks, > > Andrei Sekretenko > >
Review Request 71560: Made the MaintenanceInverseOffers test use only one framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71560/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu. Bugs: MESOS-9980 https://issues.apache.org/jira/browse/MESOS-9980 Repository: mesos Description --- This patch simplifies the test and attepmts to fix MESOS-9980 by removing the (potential) flakiness caused by agent2's resources being re-offered to framework2. Diffs - src/tests/hierarchical_allocator_tests.cpp a13eb017f7a93ee67c8426e4150858a547175ed6 Diff: https://reviews.apache.org/r/71560/diff/1/ Testing --- `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" --gtest_break_on_failure --gtest_repeat=1` `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" --gtest_break_on_failure` fails if I break framework untracking in `Slave::increaseAvailable()` in the allocator. Thanks, Andrei Sekretenko
