Re: Review Request 71643: Logged failed TLS reverse DNS lookups as warnings for 'legacy' scheme.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71643/#review218335 --- Ship it! Ship It! - Benno Evers On Oct. 22, 2019, 12:06 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71643/ > --- > > (Updated Oct. 22, 2019, 12:06 a.m.) > > > Review request for mesos, Benno Evers and Vinod Kone. > > > Bugs: MESOS-10017 > https://issues.apache.org/jira/browse/MESOS-10017 > > > Repository: mesos > > > Description > --- > > These were getting logged at VLOG(2), whereas we want all networking > related errors to be logged as warnings (or errors if appropriate). > > > Diffs > - > > 3rdparty/libprocess/src/openssl.cpp > 832a1e17614d8ae67893d5f04d3ed5a0d0efb069 > > > Diff: https://reviews.apache.org/r/71643/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Benjamin Mahler > >
Re: Review Request 71643: Logged failed TLS reverse DNS lookups as warnings for 'legacy' scheme.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71643/#review218317 --- Bad patch! Reviews applied: [71643] Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee build_71643"] Error: .. KAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess -DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src -I../boost-1.65.0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3. 0 -I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include -DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c ../../../3rdparty/libprocess/src/clock.cpp -fPIC -DPIC -o src/.libs/libprocess_la-clock.o libtool: compile: g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess -DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src -I../boost-1.65. 0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include -DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c ../../../3rdparty/libprocess/src/authenticator.cpp -fPIC -DPIC -o src/.libs/libprocess_la-authenticator.o libtool: compile: g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess -DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" -I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src -I../boost-1.65. 0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include -DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/in
Review Request 71643: Logged failed TLS reverse DNS lookups as warnings for 'legacy' scheme.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71643/ --- Review request for mesos, Benno Evers and Vinod Kone. Bugs: MESOS-10017 https://issues.apache.org/jira/browse/MESOS-10017 Repository: mesos Description --- These were getting logged at VLOG(2), whereas we want all networking related errors to be logged as warnings (or errors if appropriate). Diffs - 3rdparty/libprocess/src/openssl.cpp 832a1e17614d8ae67893d5f04d3ed5a0d0efb069 Diff: https://reviews.apache.org/r/71643/diff/1/ Testing --- make check Thanks, Benjamin Mahler
