Re: Review Request 71652: Avoid double reaping race in the command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71652/#review218354 --- Ship it! Ship It! - Vinod Kone On Oct. 23, 2019, 3:52 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71652/ > --- > > (Updated Oct. 23, 2019, 3:52 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-10007 > https://issues.apache.org/jira/browse/MESOS-10007 > > > Repository: mesos > > > Description > --- > > Previously, it was possible for the command executor to miss > the exit status of the subprocess since it performs its own > reap and doesn't use the Subprocess::status. See MESOS-10007. > > > Diffs > - > > src/launcher/executor.cpp d9b39e5a66eb7bc739dede52f43da8ca9f7c09d1 > > > Diff: https://reviews.apache.org/r/71652/diff/1/ > > > Testing > --- > > make check + manual testing from Charles in JIRA > > > Thanks, > > Benjamin Mahler > >
Re: Review Request 71652: Avoid double reaping race in the command executor.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71652/#review218351
---
Bad patch!
Reviews applied: [71652]
Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04'
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee
build_71652"]
Error:
..
24; ports:[31000-32000]; disk(reservations:
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_iXVDxw/2GB-31d22435-1c20-4b95-a133-7ab0f68239d1,test)]:2048,
offered or allocated: {}) on agent 8b74f172-6660-452a-b8f4-44d69129bd0c-S0
from framework 8b74f172-6660-452a-b8f4-44d69129bd0c-
I1023 07:58:46.228407 18972 master.cpp:12706] Removing offer
8b74f172-6660-452a-b8f4-44d69129bd0c-O3
I1023 07:58:46.230870 18970 hierarchical.cpp:1615] Framework
8b74f172-6660-452a-b8f4-44d69129bd0c- filtered agent
8b74f172-6660-452a-b8f4-44d69129bd0c-S0 for 5secs
I1023 07:58:46.233952 18966 master.cpp:12571] Sending operation '' (uuid:
4cfdc6ca-5cc7-4191-b168-c57673c55e81) to agent
8b74f172-6660-452a-b8f4-44d69129bd0c-S0 at slave(1249)@172.17.0.2:38971
(4574622b6dd8)
I1023 07:58:46.234721 18978 slave.cpp:4352] Ignoring new checkpointed resources
and operations identical to the current version
I1023 07:58:46.237903 18958 master.cpp:6412] Processing REVIVE call for
framework 8b74f172-6660-452a-b8f4-44d69129bd0c- (default) at
scheduler-4e29bb53-3c92-4102-a204-eb032bb2529a@172.17.0.2:38971
I1023 07:58:46.238562 18975 hierarchical.cpp:1711] Unsuppressed offers and
cleared filters for roles { storage/default-role } of framework
8b74f172-6660-452a-b8f4-44d69129bd0c-
I1023 07:58:46.239331 18963 provider.cpp:498] Received APPLY_OPERATION event
I1023 07:58:46.239405 18963 provider.cpp:1351] Received CREATE operation ''
(uuid: 4cfdc6ca-5cc7-4191-b168-c57673c55e81)
I1023 07:58:46.240499 18975 hierarchical.cpp:1843] Performed allocation for 1
agents in 1.615303ms
I1023 07:58:46.24 18975 hierarchical.cpp:1843] Performed allocation for 1
agents in 255828ns
I1023 07:58:46.241899 18974 master.cpp:10409] Sending offers [
8b74f172-6660-452a-b8f4-44d69129bd0c-O4 ] to framework
8b74f172-6660-452a-b8f4-44d69129bd0c- (default) at
scheduler-4e29bb53-3c92-4102-a204-eb032bb2529a@172.17.0.2:38971
I1023 07:58:46.242486 18972 sched.cpp:934] Scheduler::resourceOffers took
74004ns
I1023 07:58:46.253813 18957 http.cpp:1115] HTTP POST for
/slave(1249)/api/v1/resource_provider from 172.17.0.2:35270
I1023 07:58:46.255318 18968 slave.cpp:8483] Handling resource provider message
'UPDATE_OPERATION_STATUS: (uuid: 9eac9abd-2697-47f4-a5c2-a46fffa0deed) for
framework (latest state: OPERATION_FINISHED, status update state:
OPERATION_FINISHED)'
I1023 07:58:46.255730 18968 slave.cpp:8936] Updating the state of operation
with no ID (uuid: 9eac9abd-2697-47f4-a5c2-a46fffa0deed) for an operation API
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1023 07:58:46.255831 18968 slave.cpp:8690] Forwarding status update of
operation with no ID (operation_uuid: 9eac9abd-2697-47f4-a5c2-a46fffa0deed) for
an operator API call
I1023 07:58:46.256301 18962 master.cpp:12223] Updating the state of operation
'' (uuid: 9eac9abd-2697-47f4-a5c2-a46fffa0deed) for an operator API call
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I1023 07:58:46.257138 18976 slave.cpp:4352] Ignoring new checkpointed resources
and operations identical to the current version
I1023 07:58:46.334250 18972 status_update_manager_process.hpp:152] Received
operation status update OPERATION_FINISHED (Status UUID:
9bdddc3b-fb07-46d6-b924-212ab36ef6c6) for operation UUID
4cfdc6ca-5cc7-4191-b168-c57673c55e81 on agent
8b74f172-6660-452a-b8f4-44d69129bd0c-S0
I1023 07:58:46.334384 18972 status_update_manager_process.hpp:414] Creating
operation status update stream 4cfdc6ca-5cc7-4191-b168-c57673c55e81
checkpoint=true
I1023 07:58:46.334528 18963 provider.cpp:498] Received
ACKNOWLEDGE_OPERATION_STATUS event
I1023 07:58:46.334925 18972 status_update_manager_process.hpp:929]
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status
UUID: 9bdddc3b-fb07-46d6-b924-212ab36ef6c6) for operation UUID
4cfdc6ca-5cc7-4191-b168-c57673c55e81 on agent
8b74f172-6660-452a-b8f4-44d69129bd0c-S0
I1023 07:58:46.409291 18972 status_update_manager_process.hpp:528] Forwarding
operation status update OPERATION_FINISHED (Status UUID:
9bdddc3b-fb07-46d6-b924-212ab36ef6c6) for operation UUID
4cfdc6ca-5cc7-4191-b168-c57673c55e81 on agent
8b74f172-6660-452a-b8f4-44d69129bd0c-S0
I1023 07:58:46.
Review Request 71652: Avoid double reaping race in the command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71652/ --- Review request for mesos, Gilbert Song, Greg Mann, Qian Zhang, and Vinod Kone. Bugs: MESOS-10007 https://issues.apache.org/jira/browse/MESOS-10007 Repository: mesos Description --- Previously, it was possible for the command executor to miss the exit status of the subprocess since it performs its own reap and doesn't use the Subprocess::status. See MESOS-10007. Diffs - src/launcher/executor.cpp d9b39e5a66eb7bc739dede52f43da8ca9f7c09d1 Diff: https://reviews.apache.org/r/71652/diff/1/ Testing --- make check + manual testing from Charles in JIRA Thanks, Benjamin Mahler
