Re: Review Request 71666: WIP: SSL Wrapper: Implemented send/recv and shutdown.

2019-10-30 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218472
---



Patch looks great!

Reviews applied: [71659, 71660, 71661, 71662, 71663, 71664, 71665, 71666]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 31, 2019, 1:35 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71666/
> ---
> 
> (Updated Oct. 31, 2019, 1:35 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-10010
> https://issues.apache.org/jira/browse/MESOS-10010
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This completes a fully functional client-side SSL socket.
> 
> Needs a bit of cleanup and more error handling though.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
>   3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71666/diff/2/
> 
> 
> Testing
> ---
> 
> Successfully fetched from a webpage:
> ```
>   http::URL url = http::URL(
>  "https",
>  "www.google.com",
>  443);
> 
>   Future response = http::get(url);
>   AWAIT_READY(response);
>   EXPECT_EQ(http::Status::OK, response->code);
> ```
> 
> Running libprocess-tests yields:
> ```
> [  FAILED  ] SSLTest.SilentSocket (hangs indefinitely)
> [  FAILED  ] SSLTest.ValidDowngrade
> [  FAILED  ] SSLTest.ValidDowngradeEachProtocol
> [  FAILED  ] SSLTest.ShutdownThenSend
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 71666: WIP: SSL Wrapper: Implemented send/recv and shutdown.

2019-10-30 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/
---

(Updated Oct. 30, 2019, 6:35 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
Toenshoff.


Bugs: MESOS-10010
https://issues.apache.org/jira/browse/MESOS-10010


Repository: mesos


Description
---

This completes a fully functional client-side SSL socket.

Needs a bit of cleanup and more error handling though.


Diffs (updated)
-

  3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
  3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71666/diff/2/

Changes: https://reviews.apache.org/r/71666/diff/1-2/


Testing (updated)
---

Successfully fetched from a webpage:
```
  http::URL url = http::URL(
 "https",
 "www.google.com",
 443);

  Future response = http::get(url);
  AWAIT_READY(response);
  EXPECT_EQ(http::Status::OK, response->code);
```

Running libprocess-tests yields:
```
[  FAILED  ] SSLTest.SilentSocket (hangs indefinitely)
[  FAILED  ] SSLTest.ValidDowngrade
[  FAILED  ] SSLTest.ValidDowngradeEachProtocol
[  FAILED  ] SSLTest.ShutdownThenSend
```


Thanks,

Joseph Wu

Re: Review Request 71666: WIP: SSL Wrapper: Implemented send/recv and shutdown.

2019-10-23 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218381
---



Bad patch!

Reviews applied: [71659, 71660, 71661, 71662, 71663, 71664, 71665, 71666]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71666"]

Error:
..
incipal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I1024 04:09:16.837707 18970 sched.cpp:960] Rescinded offer 
4e513900-c18f-44fd-b61e-94980d41083c-O3
I1024 04:09:16.837848 18970 sched.cpp:971] Scheduler::offerRescinded took 
43513ns
I1024 04:09:16.838539 18964 hierarchical.cpp:1566] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_9tOuB1/2GB-8ec4d43b-5633-47b6-85bd-6e180958bc84,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_9tOuB1/2GB-8ec4d43b-5633-47b6-85bd-6e180958bc84,test)]:2048,
 offered or allocated: {}) on agent 4e513900-c18f-44fd-b61e-94980d41083c-S0 
from framework 4e513
 900-c18f-44fd-b61e-94980d41083c-
I1024 04:09:16.838770 18959 master.cpp:12706] Removing offer 
4e513900-c18f-44fd-b61e-94980d41083c-O3
I1024 04:09:16.840548 18964 hierarchical.cpp:1615] Framework 
4e513900-c18f-44fd-b61e-94980d41083c- filtered agent 
4e513900-c18f-44fd-b61e-94980d41083c-S0 for 5secs
I1024 04:09:16.844607 18958 master.cpp:12571] Sending operation '' (uuid: 
431a5832-b5dc-4070-8864-e5905e28b81e) to agent 
4e513900-c18f-44fd-b61e-94980d41083c-S0 at slave(1245)@172.17.0.2:42005 
(af3ba927af2a)
I1024 04:09:16.845479 18958 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1024 04:09:16.848281 18963 master.cpp:6412] Processing REVIVE call for 
framework 4e513900-c18f-44fd-b61e-94980d41083c- (default) at 
scheduler-fae671da-508d-496e-9b21-5f0e8463bce6@172.17.0.2:42005
I1024 04:09:16.849131 18960 hierarchical.cpp:1711] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
4e513900-c18f-44fd-b61e-94980d41083c-
I1024 04:09:16.849989 18969 provider.cpp:498] Received APPLY_OPERATION event
I1024 04:09:16.850067 18969 provider.cpp:1351] Received CREATE operation '' 
(uuid: 431a5832-b5dc-4070-8864-e5905e28b81e)
I1024 04:09:16.851294 18960 hierarchical.cpp:1843] Performed allocation for 1 
agents in 1.70449ms
I1024 04:09:16.852298 18959 master.cpp:10409] Sending offers [ 
4e513900-c18f-44fd-b61e-94980d41083c-O4 ] to framework 
4e513900-c18f-44fd-b61e-94980d41083c- (default) at 
scheduler-fae671da-508d-496e-9b21-5f0e8463bce6@172.17.0.2:42005
I1024 04:09:16.852977 18965 sched.cpp:934] Scheduler::resourceOffers took 
71323ns
I1024 04:09:16.863402 18955 http.cpp:1115] HTTP POST for 
/slave(1245)/api/v1/resource_provider from 172.17.0.2:36920
I1024 04:09:16.865109 18953 slave.cpp:8483] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: e7bbe480-05f9-4f0e-9b53-7d2bb48e9a73) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I1024 04:09:16.865459 18953 slave.cpp:8936] Updating the state of operation 
with no ID (uuid: e7bbe480-05f9-4f0e-9b53-7d2bb48e9a73) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1024 04:09:16.865547 18953 slave.cpp:8690] Forwarding status update of 
operation with no ID (operation_uuid: e7bbe480-05f9-4f0e-9b53-7d2bb48e9a73) for 
an operator API call
I1024 04:09:16.866223 18972 master.cpp:12223] Updating the state of operation 
'' (uuid: e7bbe480-05f9-4f0e-9b53-7d2bb48e9a73) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I1024 04:09:16.867074 18968 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1024 04:09:16.950788 18959 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
a12dedde-ff62-4851-ab61-9768f77a0a3d) for operation UUID 
431a5832-b5dc-4070-8864-e5905e28b81e on agent 
4e513900-c18f-44fd-b61e-94980d41083c-S0
I1024

Review Request 71666: WIP: SSL Wrapper: Implemented send/recv and shutdown.

2019-10-23 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/
---

Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
Toenshoff.


Bugs: MESOS-10010
https://issues.apache.org/jira/browse/MESOS-10010


Repository: mesos


Description
---

This completes a fully functional client-side SSL socket.

Needs a bit of cleanup and more error handling though.


Diffs
-

  3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
  3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71666/diff/1/


Testing
---

Successfully fetched from a webpage:
```
  http::URL url = http::URL(
 "https",
 "www.google.com",
 443);

  Future response = http::get(url);
  AWAIT_READY(response);
  EXPECT_EQ(http::Status::OK, response->code);
```


Thanks,

Joseph Wu