Re: Review Request 71700: Updated offer operation resource validation for reservation updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/#review218535 --- Ship it! Patch looks great! - Benjamin Bannier On Oct. 29, 2019, 7:13 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71700/ > --- > > (Updated Oct. 29, 2019, 7:13 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Updated `validateAndUpgradeResources()` to also validate the `source` > field in a reservation. > > > Diffs > - > > src/common/resources_utils.cpp cbdad4b045ad957b2ab1fd09a6b9fb12bb4fb523 > > > Diff: https://reviews.apache.org/r/71700/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 71700: Updated offer operation resource validation for reservation updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/#review218511 --- Patch looks great! Reviews applied: [71679, 71686, 71699, 71687, 71688, 71690, 71695, 71696, 71700] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 29, 2019, 6:13 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71700/ > --- > > (Updated Oct. 29, 2019, 6:13 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Updated `validateAndUpgradeResources()` to also validate the `source` > field in a reservation. > > > Diffs > - > > src/common/resources_utils.cpp cbdad4b045ad957b2ab1fd09a6b9fb12bb4fb523 > > > Diff: https://reviews.apache.org/r/71700/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 71700: Updated offer operation resource validation for reservation updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/#review218504 --- Patch looks great! Reviews applied: [71679, 71686, 71699, 71687, 71688, 71690, 71695, 71696, 71700] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 29, 2019, 6:13 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71700/ > --- > > (Updated Oct. 29, 2019, 6:13 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Updated `validateAndUpgradeResources()` to also validate the `source` > field in a reservation. > > > Diffs > - > > src/common/resources_utils.cpp cbdad4b045ad957b2ab1fd09a6b9fb12bb4fb523 > > > Diff: https://reviews.apache.org/r/71700/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 71700: Updated offer operation resource validation for reservation updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/#review218485 --- Bad review! Reviews applied: [71700, 71696, 71695, 71690, 71688, 71687, 71699, 71686, 71679] Error: 2019-11-01 17:04:10 URL:https://reviews.apache.org/r/71695/diff/raw/ [5000/5000] -> "71695.patch" [1] error: patch failed: src/master/http.cpp:2010 error: src/master/http.cpp: patch does not apply - Mesos Reviewbot On Oct. 29, 2019, 6:13 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71700/ > --- > > (Updated Oct. 29, 2019, 6:13 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > --- > > Updated `validateAndUpgradeResources()` to also validate the `source` > field in a reservation. > > > Diffs > - > > src/common/resources_utils.cpp cbdad4b045ad957b2ab1fd09a6b9fb12bb4fb523 > > > Diff: https://reviews.apache.org/r/71700/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >
Re: Review Request 71700: Updated offer operation resource validation for reservation updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/#review218439 --- Bad patch! Reviews applied: [71679, 71686, 71699, 71687, 71688, 71690, 71695, 71696, 71700] Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee build_71700"] Error: .. obuf/internal/factory_test1_pb2.py to factory_test1_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/packed_field_test_pb2.py to packed_field_test_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/well_known_types.py to well_known_types.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/text_encoding_test.py to text_encoding_test.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/type_checkers.py to type_checkers.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/wire_format_test.py to wire_format_test.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/api_implementation.py to api_implementation.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/symbol_database_test.py to symbol_database_test.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/message_factory_test.py to message_factory_test.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/reflection_test.py to reflection_test.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/any_test_pb2.py to any_test_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/import_test_package/outer_pb2.py to outer_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/import_test_package/inner_pb2.py to inner_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/import_test_package/__init__.py to __init__.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/descriptor_test.py to descriptor_test.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/message_test.py to message_test.pyc /bin/bash ../libtool --tag=CXX --mode=compile g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. -I../../src -Werror -DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" -DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" -DPKGDATADIR=\"/mesos/mesos-1. 10.0/_inst/share/mesos\" -DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include -I../include -I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include -I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include -I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c -o authentication/cram_md5/libmesos_no_3rdparty_la-authenticatee.lo `test -f 'authentication/cram_md5/authenticatee.cp p' || echo '../../src/'`authentication/cram_md5/authenticatee.cpp byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/internal/file_options_test_pb2.py to file_options_test_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/timestamp_pb2.py to timestamp_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/struct_pb2.py to struct_pb2.pyc byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/map_unittest_pb2.py to map_unittest_pb2.pyc byte-compiling
Review Request 71700: Updated offer operation resource validation for reservation updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description --- Updated `validateAndUpgradeResources()` to also validate the `source` field in a reservation. Diffs - src/common/resources_utils.cpp cbdad4b045ad957b2ab1fd09a6b9fb12bb4fb523 Diff: https://reviews.apache.org/r/71700/diff/1/ Testing --- Thanks, Benno Evers
