Re: Review Request 71742: Mesos agent responds pings only from currently registered master

2019-11-08 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71742/#review218582
---



Bad patch!

Reviews applied: [71742]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71742"]

Error:
..
pp:12794] Removing offer bf518529-d351-4a8b-bba1-60fa38542add-O3
I1109 00:29:33.548925 18798 hierarchical.cpp:1625] Framework 
bf518529-d351-4a8b-bba1-60fa38542add- filtered agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0 for 5secs
I1109 00:29:33.551477 18811 master.cpp:12659] Sending operation '' (uuid: 
c3cd8267-059a-45e5-8a23-6a8a1e83d593) to agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0 at slave(1250)@172.17.0.2:36833 
(7a92e10ffb12)
I1109 00:29:33.552137 18811 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1109 00:29:33.555243 18797 provider.cpp:498] Received APPLY_OPERATION event
I1109 00:29:33.555289 18797 provider.cpp:1351] Received CREATE operation '' 
(uuid: c3cd8267-059a-45e5-8a23-6a8a1e83d593)
I1109 00:29:33.560374 18801 master.cpp:6482] Processing REVIVE call for 
framework bf518529-d351-4a8b-bba1-60fa38542add- (default) at 
scheduler-3dd25b70-0173-473f-abee-d49864755156@172.17.0.2:36833
I1109 00:29:33.560904 18803 hierarchical.cpp:1721] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
bf518529-d351-4a8b-bba1-60fa38542add-
I1109 00:29:33.562279 18803 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.196644ms
I1109 00:29:33.562737 18803 hierarchical.cpp:1853] Performed allocation for 1 
agents in 205894ns
I1109 00:29:33.563107 18807 master.cpp:10497] Sending offers [ 
bf518529-d351-4a8b-bba1-60fa38542add-O4 ] to framework 
bf518529-d351-4a8b-bba1-60fa38542add- (default) at 
scheduler-3dd25b70-0173-473f-abee-d49864755156@172.17.0.2:36833
I1109 00:29:33.563773 18807 sched.cpp:934] Scheduler::resourceOffers took 
82563ns
I1109 00:29:33.578168 18808 http.cpp:1115] HTTP POST for 
/slave(1250)/api/v1/resource_provider from 172.17.0.2:48892
I1109 00:29:33.579185 18798 slave.cpp:8493] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 1bc3ea7a-a5ea-437a-8916-3880131439b3) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I1109 00:29:33.579345 18798 slave.cpp:8946] Updating the state of operation 
with no ID (uuid: 1bc3ea7a-a5ea-437a-8916-3880131439b3) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1109 00:29:33.579398 18798 slave.cpp:8700] Forwarding status update of 
operation with no ID (operation_uuid: 1bc3ea7a-a5ea-437a-8916-3880131439b3) for 
an operator API call
I1109 00:29:33.579720 18802 master.cpp:12311] Updating the state of operation 
'' (uuid: 1bc3ea7a-a5ea-437a-8916-3880131439b3) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I1109 00:29:33.580221 18810 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1109 00:29:33.653975 18798 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
0a105a21-ea89-4c39-a698-7206b4518659) for operation UUID 
c3cd8267-059a-45e5-8a23-6a8a1e83d593 on agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0
I1109 00:29:33.654039 18798 status_update_manager_process.hpp:414] Creating 
operation status update stream c3cd8267-059a-45e5-8a23-6a8a1e83d593 
checkpoint=true
I1109 00:29:33.654115 18797 provider.cpp:498] Received 
ACKNOWLEDGE_OPERATION_STATUS event
I1109 00:29:33.654314 18798 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: 0a105a21-ea89-4c39-a698-7206b4518659) for operation UUID 
c3cd8267-059a-45e5-8a23-6a8a1e83d593 on agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0
I1109 00:29:33.720492 18798 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
0a105a21-ea89-4c39-a698-7206b4518659) for operation UUID 
c3cd8267-059a-45e5-8a23-6a8a1e83d593 on agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0
I1109 00:29:33.720772 18798 status_update_manager_process.hpp:252] Received 
operation status update acknowledgement (UUID: 
eb231693-b2bc-4738-9dbb-a860839dacff) for stream 
1bc3ea7a-a5ea-437a-8916-3880131439b3
I1109 00:29:33.720830 18798 status_update_manager_process.hpp:929] 
Checkpointing ACK for operation status update OPERATION_FINISHED (Status UUID: 
eb231693-b2bc-4738-9dbb-a860839dacff) for operation UUID 
1bc3ea7a-a5ea-437a-8916-3880131439b3 on agent 

Review Request 71742: Mesos agent responds pings only from currently registered master

2019-11-08 Thread Xudong Ni via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71742/
---

Review request for mesos.


Bugs: MESOS-10032
https://issues.apache.org/jira/browse/MESOS-10032


Repository: mesos


Description
---

In the case agents lost ZooKeeper connections and resetting its
master to None and beginning to dropping control messages from the
master, agent should not respond pings from that master.


Diffs
-

  src/slave/slave.cpp 3839a120446339fea8aa857f431a2dba28ed4002 


Diff: https://reviews.apache.org/r/71742/diff/1/


Testing
---


Thanks,

Xudong Ni