Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8079#discussion_r36717693
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -43,36 +42,60 @@ import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8079#discussion_r36717291
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -43,36 +42,60 @@ import
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8013#issuecomment-128749989
Still a lot of duplication. We're adding new features into LiR now, and it
will be hard to maintain. Is it possible that you just add the objective
function, an
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128460615
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128445677
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128302571
@jkbradley and @mengxr This PR is ready for review. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128295310
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128295375
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-128289808
Jenkins, please test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127849756
@rotationsymmetry Please help to create the JIRA. For `LinearRegression`,
that should be smilier to this one. Once this one is merged, we can start to
port it to
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7875#issuecomment-127797035
++1 for refactoring the code so LoR and LiR can share the duplicated code.
I would like to work on it post 1.5.
---
If your project is set up for it, you can reply to
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127771793
@jkbradley and @mengxr I had `weightCol` as empty as default in my local
branch. Sorry for confusion. This PR is meant to be WIP to see if we have
enough time to make
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36237450
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -250,6 +267,23 @@ private[ml] trait HasStandardization extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36236527
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -88,6 +88,23 @@ private[ml] trait HasLabelCol extends Params
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36226698
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -114,20 +114,40 @@ class LogisticRegression(override val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36164446
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -114,20 +114,40 @@ class LogisticRegression(override val
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127507930
Jenkins, please test again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127505014
This is very useful for us as well. Our training samples will have
exponential decay weight as time goes by. I am trying to use it now, and it
seems work well. Will be
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36162618
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -451,11 +471,14 @@ private class LogisticAggregator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36162580
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -451,11 +471,14 @@ private class LogisticAggregator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36162497
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -114,20 +114,40 @@ class LogisticRegression(override val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r36162455
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -114,20 +114,40 @@ class LogisticRegression(override val
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-127463103
@jkbradley Sounds fair. I will also add tests now. BTW, can you merge
https://github.com/apache/spark/pull/7875/files which is already ready to be
merged. I will have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7722#issuecomment-127462789
Please add the unit tests. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7875#discussion_r36154117
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -85,6 +85,18 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7875#issuecomment-127461865
cc @jkbradley Can you help me to code review this PR? This one is pretty
much the same as
https://github.com/apache/spark/commit/57221934e0376e5bb8421dc35d4bf91db4deeca1
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/7884
[SPARK-7685][ML] Apply weights to different samples in Logistic Regression
In fraud detection dataset, almost all the samples are negative while only
couple of them are positive. This type of high
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7875#discussion_r36049772
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -456,6 +480,7 @@ class LinearRegressionSummary private[regression
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7875#discussion_r36049752
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -85,6 +85,18 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7875#discussion_r36049732
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -85,6 +85,18 @@ class LinearRegression(override val uid: String
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/7875
[SPARK-8601][ML] Add an option to disable standardization for linear
regression
All compressed sensing applications, and some of the regression use-cases
will have better result by turning the
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7722#issuecomment-126524084
We also need the unit-tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7722#discussion_r35935046
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,609 @@
+/*
+ * Licensed to the Apache Software
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7722#issuecomment-126522448
I will have them in the same `LinearRegression` codebase as @mengxr said.
Almost 90% of the code is the same, and it will be hard to maintain. BTW, I can
take over this
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-126519222
Are we going to have `invert` or `unapply` in the `Transformer` trait? In
scala, there is an extractor pattern
http://docs.scala-lang.org/tutorials/tour/extractor
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7037#issuecomment-123189976
@holdenk can you merge master? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7371#issuecomment-123189496
LGTM except minor formatting issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7371#discussion_r35073930
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -155,6 +158,9 @@ class LogisticRegressionModel
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/5503#issuecomment-123188002
jenkins, ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/5503#issuecomment-123187717
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/5503#issuecomment-123187427
jenkins, please test this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7553#issuecomment-123163210
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7553#issuecomment-123151544
LGTM except minor styling issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7553#discussion_r35068725
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -55,6 +56,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7553#discussion_r35068701
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -55,6 +56,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7371#issuecomment-120994938
@mengxr Sure. I will take over. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7335#issuecomment-120201785
Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7327#issuecomment-120168487
Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7327#issuecomment-120156608
Please submit separate PR for LoR. Please add new story for cleaning up LiR
test code, and update the title. This one is ready to be merged.
---
If your project is set
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7327#issuecomment-120155810
This JIRA is for cleaning test in LoR but you are cleaning LiR in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7327#issuecomment-120151418
LGTM. But this is cleanup for LiR. Please create another JIRA for this, and
update the title. Thanks.
---
If your project is set up for it, you can reply to this email
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7080#issuecomment-119748738
@holdenk I assigned https://issues.apache.org/jira/browse/SPARK-8913 to
you. Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r34204113
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -232,16 +236,26 @@ class LogisticRegressionSuite
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7080#issuecomment-119735922
@mengxr Let's merge it first, and I will find someone to work on this this
weekend. Thanks.
---
If your project is set up for it, you can reply to this email and
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7080#issuecomment-119410885
BTW: Will have more documentation in the followup PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7245#discussion_r34088452
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -186,39 +186,49 @@ class LogisticRegression(override val
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r34015538
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -212,12 +230,139 @@ class LinearRegressionModel private[ml
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r34015350
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -212,12 +230,139 @@ class LinearRegressionModel private[ml
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-119107982
In general, the losses returned from optimizer are for debugging purpose,
and users can see how well the optimizer works. The reason is the real
statistical metrics
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r34002394
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -212,12 +230,139 @@ class LinearRegressionModel private[ml
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r34002320
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -140,7 +142,16 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33999324
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -194,10 +203,15 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7099#discussion_r33988929
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -194,10 +203,15 @@ class LinearRegression(override val uid: String
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/7245
[SPARK-8845] [ML] ML use of Breeze optimization: use adjustedValue instead
of value
In LinearRegression and LogisticRegression, we use Breeze's optimizers
(LBFGS and OWLQN). We chec
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r33752237
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -292,20 +317,51 @@ class LogisticRegressionSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r33749927
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -98,6 +98,15 @@ class LogisticRegression(override val uid
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7037#issuecomment-117831062
@holdenk Cool. I'll work on this tonight. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dbtsai closed the pull request at:
https://github.com/apache/spark/pull/1518
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7037#issuecomment-117035158
You don't cover all the test cases including with/without intercept. Also,
for regParam = 0, they should converge to the same solution.
---
If your project is s
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7037#discussion_r33546141
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -82,6 +82,15 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6946#issuecomment-117022967
Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7080#issuecomment-117001396
Jenkins, please test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7080#issuecomment-116955865
Jenkins, please test again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r33532097
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -208,8 +208,11 @@ class LogisticRegressionSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r33532011
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -534,27 +554,39 @@ private class LogisticCostFun
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/7080
[SPARK-8700][ML] Disable feature scaling in Logistic Regression
All compressed sensing applications, and some of the regression use-cases
will have better result by turning the feature scaling off
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7024#issuecomment-115571567
Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7024#issuecomment-115564492
LGTM. Can you create a subtask in JIRA and update the #? Otherwise, the
merging script will get confused. Also change [MLLIB] to [ML]
---
If your project is set up for
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7024#discussion_r33288184
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -53,6 +53,7 @@ private[shared] object SharedParamsCodeGen
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6946#issuecomment-115131705
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6946#issuecomment-115050717
This is for LoR, how about LiR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6927#issuecomment-114621006
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6927#issuecomment-114389143
Although `LeastSquaresAggregator` and `LeastSquaresCostFun` are private,
`MiMa` is not happy about the changes.
```
[error] * method
this
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33015106
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,14 +35,24 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33014984
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -78,6 +89,43 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33014800
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -26,7 +26,7 @@ import org.apache.spark.Logging
import
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33000481
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -106,6 +156,37 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r33000469
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -161,4 +272,34 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6927#issuecomment-114027727
LGTM except minor issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32909342
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,14 +35,20 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32903263
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -78,6 +85,49 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32903235
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,14 +35,20 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32902999
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -34,14 +35,20 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32902975
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -133,7 +144,11 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32902955
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -121,8 +131,9 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6927#discussion_r32902830
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -73,6 +74,15 @@ class LinearRegression(override val uid: String
Github user dbtsai closed the pull request at:
https://github.com/apache/spark/pull/6045
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/5503#issuecomment-111651809
jenkins, please test this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6339#issuecomment-111651729
This will be useful. But should be have inverse transform api in the parent
class?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/6768#issuecomment-111651422
Merged into master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1301 - 1400 of 1803 matches
Mail list logo
