huaxingao commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-724147848
Thank you! @cloud-fan
This is an automated message from the Apache Git Service.
To respond to the message, pl
huaxingao commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-723167036
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
huaxingao commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-721550399
> Does it conflict with the dialect API to generate CREATE TABLE statement?
No, it doesn't conflict with the dialect API to generate CREATE TABLE
statement. The table pr
huaxingao commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-721542287
> when users specify some table properties, JDBC V2 should fail if the
underlying database can't support the properties.
I agree JDBC V2 should fail if the underlying da
huaxingao commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-719111570
> We also need to retrieve the table comment in `TableCatalog.loadTable`
So we will retrieve table comment using a query and then set this comment in
`JDBCOptions` in `J
huaxingao commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-716987003
cc @cloud-fan @maropu @MaxGekk @ScrapCodes
This is an automated message from the Apache Git Service.
To respo
huaxingao commented on pull request #30154:
URL: https://github.com/apache/spark/pull/30154#issuecomment-716922392
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
