Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19663#discussion_r149015858 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -705,6 +705,19 @@ private[spark] class Client( } } + val confDir = + sys.env.getOrElse("SPARK_CONF_DIR", sys.env("SPARK_HOME") + File.separator + "conf") + val dir = new File(confDir) + if (dir.isDirectory) { + val files = dir.listFiles(new FileFilter { + override def accept(pathname: File): Boolean = { + pathname.isFile && pathname.getName.endsWith("xml") --- End diff -- Shall we explicitly match the file name, like "hive-site.xml"? Looks like only check file name ends with "xml" will also include other unwanted files indefinitely.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org