[GitHub] spark pull request #21074: [SPARK-21811][SQL] Fix the inconsistency behavior...

2018-04-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21074#discussion_r181620108 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -178,7 +178,13 @@ object TypeCoercion {

[GitHub] spark issue #21024: [SPARK-23917][SQL] Add array_max function

2018-04-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21024 LGTM. Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #21024: [SPARK-23917][SQL] Add array_max function

2018-04-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21024 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21025: [SPARK-23918][SQL] Add array_min function

2018-04-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21025 @mgaido91 Could you address the conflicts? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #21031: [SPARK-23923][SQL] Add cardinality function

2018-04-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21031#discussion_r181621963 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3282,6 +3282,14 @@ object functions { */ def size(e:

[GitHub] spark issue #20611: [SPARK-23425][SQL]Support wildcard in HDFS path for load...

2018-04-15 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/spark/pull/20611 @wzhfy @HyukjinKwon @jiangxb1987 @gatorsmile @vinodkc All test-cases has been passed, please let me know for any other suggestions. With current solution following improvement has

[GitHub] spark issue #20535: [SPARK-23341][SQL] define some standard options for data...

2018-04-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20535 **[Test build #89382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89382/testReport)** for PR 20535 at commit

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181614224 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #20940: [SPARK-23429][CORE] Add executor memory metrics t...

2018-04-15 Thread edwinalu
Github user edwinalu commented on a diff in the pull request: https://github.com/apache/spark/pull/20940#discussion_r181611071 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -234,8 +244,22 @@ private[spark] class EventLoggingListener(

[GitHub] spark issue #21047: [SPARK-23956][YARN] Use effective RPC port in AM registr...

2018-04-15 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/21047 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21047: [SPARK-23956][YARN] Use effective RPC port in AM registr...

2018-04-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21047 **[Test build #89384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89384/testReport)** for PR 21047 at commit

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181616266 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -105,4 +106,26 @@ class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181613044 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181613270 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181615751 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,60 @@ case class

[GitHub] spark pull request #21037: [SPARK-23919][SQL] Add array_position function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21037#discussion_r181614388 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,61 @@ case class

[GitHub] spark pull request #21047: [SPARK-23956][YARN] Use effective RPC port in AM ...

2018-04-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21047 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21074: [SPARK-21811][SQL] Fix the inconsistency behavior...

2018-04-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21074#discussion_r181619518 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -178,7 +178,13 @@ object TypeCoercion {

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181619426 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181617303 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala --- @@ -354,3 +336,37 @@ case class

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181619450 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181618055 --- Diff: python/pyspark/sql/functions.py --- @@ -1846,6 +1846,27 @@ def array_contains(col, value): return

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181623803 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181623729 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181624253 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

[GitHub] spark pull request #21033: [SPARK-19320][MESOS]allow specifying a hard limit...

2018-04-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21033#discussion_r181627739 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -495,9

[GitHub] spark issue #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21053 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89383/ Test FAILed. ---

[GitHub] spark issue #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21053 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21053 **[Test build #89383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89383/testReport)** for PR 21053 at commit

[GitHub] spark issue #20535: [SPARK-23341][SQL] define some standard options for data...

2018-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20535 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20535: [SPARK-23341][SQL] define some standard options for data...

2018-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20535 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2333/

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181610494 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -413,6 +413,78 @@ class DataFrameFunctionsSuite extends QueryTest

[GitHub] spark issue #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21053 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2334/

[GitHub] spark issue #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21053 **[Test build #89383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89383/testReport)** for PR 21053 at commit

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-15 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21074 cc @HyukjinKwon @gatorsmile @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21047: [SPARK-23956][YARN] Use effective RPC port in AM registr...

2018-04-15 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/21047 Merging to master. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21031: [SPARK-23923][SQL] Add cardinality function

2018-04-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21031#discussion_r181622107 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -407,6 +407,7 @@ object FunctionRegistry {

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181622879 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

[GitHub] spark pull request #21053: [SPARK-23924][SQL] Add element_at function

2018-04-15 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21053#discussion_r181623519 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,106 @@ case class

<    1   2